Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: fixes to suppress bikeshed warnings #131

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

takikawa
Copy link
Collaborator

This is a minor editorial PR that fixes most of the bikeshed warnings and adjusts linking (in particular, makes sure "map" links to the infra spec where appropriate).

There are just two warnings left after this PR:

LINE 683: Unexported dfn that's not referenced locally - did you mean to export it?
<dfn bs-line-number="683" data-dfn-for="index-map" data-dfn-type="dfn" id="index-map-offset" data-lt="offset" data-noexport="by-default" class="dfn-paneled"><code bs-line-number="683" class="highlight">offset</code></dfn>
LINE 687: Unexported dfn that's not referenced locally - did you mean to export it?
<dfn bs-line-number="687" data-dfn-for="index-map" data-dfn-type="dfn" id="index-map-map" data-lt="map" data-noexport="by-default" class="dfn-paneled"><code bs-line-number="687" class="highlight">map</code></dfn>

We could remove these dfns but we could also link them when we flesh out the index map sections in the future.

Makes very minor fixes for linking:

  * Make "map" links go to the infra spec
  * Add for tag for index map defns
  * Add ids to all sections to suppress warning
source-map.bs Outdated Show resolved Hide resolved
@jkup jkup self-requested a review September 30, 2024 19:28
This matches the spec with PR tc39#122
@jkup jkup merged commit 75f0a28 into tc39:main Oct 2, 2024
2 checks passed
github-actions bot added a commit that referenced this pull request Oct 2, 2024
SHA: 75f0a28
Reason: push, by jkup

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants