Lint for consistency in multiline vs single-line "if" and "else" #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmdyck
reviewed
Apr 20, 2023
| } | ||
| ); | ||
| }); | ||
|
|
There was a problem hiding this comment.
There should maybe be a couple tests with a mismatch between If and Else if.
michaelficarra
approved these changes
Apr 20, 2023
There was a problem hiding this comment.
Code LGTM but could use a few more tests. Two negative tests for if/else without else-if. And as @jmdyck points out, positive tests where if and else-if do not agree.
bakkot
force-pushed
the
lint-inconsistent-if
branch
from
abda892 to
cc37421
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See tc39/ecma262#3043.
Needed some minor refactoring to have enough context to apply the rule, so I recommend reviewing commits individually.
Calling this major due to adding a new on-by-default lint rule, which will break the build of most nontrivial specs.