Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

Stage 3 Criteria #19

Closed
10 tasks done
jridgewell opened this issue Oct 29, 2021 · 6 comments
Closed
10 tasks done

Stage 3 Criteria #19

jridgewell opened this issue Oct 29, 2021 · 6 comments

Comments

@jridgewell
Copy link
Member

jridgewell commented Oct 29, 2021 •
edited
Loading

@bakkot
Copy link
Contributor

bakkot commented Oct 29, 2021

Spec text LGTM except for #20.

@ljharb ljharb mentioned this issue Oct 29, 2021
Merged
@ljharb
Copy link
Member

ljharb commented Oct 29, 2021

I've put up #21 to consolidate the shared steps between the two methods.

Other than those two PRs, LGTM!

@chicoxyzzy
Copy link
Member

chicoxyzzy commented Nov 21, 2021 •
edited
Loading

LGTM!

Sorry for such a long delay

@michaelficarra
Copy link
Member

LGTM.

@syg
Copy link

syg commented Dec 14, 2021

LGTM modulo one stylistic nit:

In AddValueToKeyedGroup I'd prefer a manual iteration of finding the right g to be consistent with other List-as-sets usage in the spec.

jridgewell added a commit that referenced this issue Dec 14, 2021
@jridgewell
Perform manual iteration in AddValueToKeyedGroup
3ab23de 
Re: #19 (comment)
@jridgewell jridgewell mentioned this issue Dec 14, 2021
Merged
jridgewell added a commit that referenced this issue Dec 14, 2021
@jridgewell
Perform manual iteration in AddValueToKeyedGroup
b53ddc2 
Re: #19 (comment)
@jridgewell jridgewell mentioned this issue Dec 14, 2021
Open
jridgewell added a commit that referenced this issue Dec 14, 2021
@jridgewell
Perform manual iteration in AddValueToKeyedGroup (#31)
db30862 
Re: #19 (comment)
@jridgewell
Copy link
Member Author

Now at Stage 3!

@ljharb ljharb mentioned this issue May 18, 2023
Closed
12 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@ljharb @syg @jridgewell @michaelficarra @chicoxyzzy @bakkot