Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider more name change fallout from 'if' --> 'assert' rename #87

Closed
dandclark opened this issue Jul 21, 2020 · 5 comments
Closed

Consider more name change fallout from 'if' --> 'assert' rename #87

dandclark opened this issue Jul 21, 2020 · 5 comments
Assignees

Comments

@dandclark
Copy link
Collaborator

#80 changed the keyword from if to assert. There are two other name changes to consider as follow-ups:

  • Rename the proposal from "Import Conditions" to "Import Assertions"
  • Rename ModuleRecord's [[Conditions]] fields to [[Assertions]]

Thoughts/objections/any other changes we're missing?

@xtuc
Copy link
Member

xtuc commented Jul 21, 2020

We might want to update Mozilla's position

@dandclark dandclark self-assigned this Jul 22, 2020
@dandclark
Copy link
Collaborator Author

Other parts of spec text also reference "conditions" (ConditionEntries, ConditionKey, AssertClauseToConditions...), so I'm renaming those as well in #88.

@dandclark
Copy link
Collaborator Author

I landed #88 and posted an update to mozilla/standards-positions#373 (if they want to change it I'll offer to submit a PR; I'm not sure if creating a PR against mozilla/standards-position as a non-Mozilla employee presumes too much 😄). So, closing this.

@xtuc
Copy link
Member

xtuc commented Jul 25, 2020

@dandclark I think it's ok to do it, like I did mozilla/standards-positions#392. I'm happy to send a PR

@dandclark
Copy link
Collaborator Author

@xtuc Oh, I didn't notice it was done that way last time. Looks like dbaron beat us to it though: mozilla/standards-positions@da63152

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants