Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change if keyword to assert #80

Merged
merged 2 commits into from
Jul 21, 2020
Merged

Change if keyword to assert #80

merged 2 commits into from
Jul 21, 2020

Conversation

dandclark
Copy link
Collaborator

Change if keyword to assert in README and spec.
Add [no LineTerminator here] prior to AssertClause.

Copy link
Member

@xtuc xtuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link
Member

@littledan littledan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change LGTM if we want to rename if to assert. I think we can decide whether we want to do this change during the TC39 meeting, and land if so.

We may want to rename [[Conditions]] to [[Assertions]] and generally rename this proposal (!) to "import assertions", but this can be a later PR.

spec.html Show resolved Hide resolved
@dandclark
Copy link
Collaborator Author

This change LGTM if we want to rename if to assert. I think we can decide whether we want to do this change during the TC39 meeting, and land if so.

We may want to rename [[Conditions]] to [[Assertions]] and generally rename this proposal (!) to "import assertions", but this can be a later PR.

Sounds good, I'll just leave this un-merged for now.
Separately I created #81 to fix the editorial issue you pointed out.

@xtuc
Copy link
Member

xtuc commented Jul 21, 2020

As discussed during the July 2020 TC39 meeting, it seems that people are in favor of switching to assert, merging this.

@xtuc xtuc merged commit 3d71669 into master Jul 21, 2020
@xtuc xtuc deleted the dandclark/if-to-assert branch July 21, 2020 21:34
@ljharb
Copy link
Member

ljharb commented Jul 21, 2020

Should the proposal be renamed as well, to "import assertions"?

@dandclark
Copy link
Collaborator Author

Should the proposal be renamed as well, to "import assertions"?

I think so, and @littledan also pointed out that the [[Conditions]] field should probably also be renamed. I filed #87 and I will make these changes if there are no objections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants