mutable JSON module #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's good to document this better, even if the spec already defines semantics. I'd avoid using the word "should" since this doesn't really correspond to the RFC 2119 definition. Instead, let's say, "is". Also, instead of talking about the Realm, let's be more concrete, and say, "all of the import statements in the module graph that address the same JSON module will evaluate to the same mutable object" |
|
I will make the changes, just focusing on #75 for now |
xtuc
force-pushed
the
sven/mutable-json-module
branch
from
f051178 to
992b663
Compare
littledan
approved these changes
Jul 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/tc39/proposal-import-attributes/issues/54
I'm really unsure about the spec language to describe that. We don't explictly call freeze so I suppose it's clear