-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normative: Delegate to NumberFormat to handle unit formattting #122
Conversation
@FrankYFTang thanks for this, I'd missed this simpler way of formatting the results which also avoids duplicating code as well as spec text. |
Probably worth mentioning this depends on tc39/ecma402#702 resp. tc39/ecma402#704 |
@anba are we blocked on that right away or for Stage 4? Practically speaking, I suppose you'd need the change in order to implement this to begin with. |
I don't know. Are there any strict guidelines which describe cases like this? It's probably okay to merge this PR, as long as there's an
Implementers can work around the |
@anba alright, thanks, that sounds good to me. I'll add a note and merge this. |
For the case of style "short", "long" and "narrow" and resolve the plural issue and reduce unnecessary locale data handling.
2127c53
to
c1464b9
Compare
Ah... I totally forgot about that dependency. Thanks for pointing that out. |
For the case of style "short", "long" and "narrow" and resolve the
plural issue and reduce unnecessary locale data handling.
This should also resolve the issue mentioned in #118
@ryzokuken @sffc @anba @gibson042 @michaelficarra @rbuckton @rkirsling -any opinion of moving toward this direction?