-
Notifications
You must be signed in to change notification settings - Fork 17
Change the ref grammar from RFC5646 to UTS35 #67
Conversation
It doesn't seem like mentioning |
I agree that it should be unicode_locale_id instead. For -t- extensions,
there are a few possible strategies.
1. explicitly say that -t- extension validity checking is optional (a
complete "carve out")
2. require syntactic checking of -t- extensions (according the the
EBNF), but not require validity checking of the keywords or values (I'd
recommend this level; the data/code requirements are low.)
3. full validity checking of keywords & values
Mark
…On Wed, Dec 19, 2018 at 3:02 PM André Bargull ***@***.***> wrote:
It doesn't seem like mentioning unicode_language_id is possible in all
cases, because unicode_language_id doesn't include extension and
privateuse sequences. There is also unicode_locale_id, which does include
extension and privateuse sequences, but it also implies validating -t-
transform extension sequences and I'm not sure we want to include this
implied validation for -t- extensions in all cases.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#67 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJKyMMPkrKg3Kx4p3L4avkNB7ZDwkmJBks5u6kbqgaJpZM4ZZH-R>
.
|
Correct all except one unicode_language_id to unicode_locale_id.
Opps ... good catch. I totally messed up. I intend to replace 'langtag' in RFC with 'unicode_locale_id' in UTS35 but somehow I messed up in this PR. Good catch. Will update my PR soon.
|
OK, I updated the PR to address the "unicode_language_id vs unicode_locale_id error" issues and also change the PR description to match the latest content in the PR. The "validating -t- transform extension" issue is not yet addressed. Should we merge this PR without address that first? and handle that in a follow up PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks good to me. It seems reasonable to do some parts in a follow-on.
spec.html
Outdated
@@ -19,49 +19,48 @@ <h1>The Intl.Locale Constructor</h1> | |||
<emu-clause id="sec-apply-options-to-tag" aoid=ApplyOptionsToTag> | |||
<h1>ApplyOptionsToTag( _tag_, _options_ )</h1> | |||
<p> | |||
The following algorithm refers to <a href="https://tools.ietf.org/html/rfc5646#section-2.1">RFC 5646's Language-Tag grammar</a>. | |||
The following algorithm refers to <a href="http://www.unicode.org/reports/tr35/#Identifiers">UTS 35's Unicode Language and Locale Identifiers grammar</a>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: this seems to work as https, so let's use that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DONE
spec.html
Outdated
@@ -142,13 +141,13 @@ <h1>InsertUnicodeExtension( _locale_, _extension_ )</h1> | |||
The InsertUnicodeExtension abstract operation inserts _extension_, which must be a Unicode locale extension sequence, into _locale_, which must be a String value with a structurally valid and canonicalized BCP 47 language tag. The following steps are taken: | |||
</p> | |||
<p> | |||
The following algorithm refers to <a href="https://tools.ietf.org/html/rfc5646#section-2.1">RFC 5646's Language-Tag grammar</a>. | |||
The following algorithm refers to <a href="http://www.unicode.org/reports/tr35/#Identifiers">UTS 35's Unicode Language and Locale Identifiers grammar</a>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You missed https here and in a few other places below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
opps! sorry
ping. Can we merge this? |
If anyone sees any issues with what's merged, please keep commenting. |
This is following up #63 after the merging of #66
a. language production -> unicode_language_subtag production
b. script production -> unicode_script_subtag production
c. region production -> unicode_region_subtag production
d. langtag production -> unicode_locale_id production (note: except 2 above)
e. Remove the reference of "grandfathered production" (see 4 below)
@littledan @gsathya @zbraniecki @anba @macchiati @jungshik @aphillips @markusicu @nciric