-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editorial: Use dotted intrinsics #263
Editorial: Use dotted intrinsics #263
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few nitpicks.
Meanwhile, it would be good to wait for feedback from @ljharb and @caridy.
We also need to keep track of tc39/ecma262#2056. At this point I believe it is gonna be merged, but sync is important.
</emu-table> | ||
<emu-clause id="sec-well-known-intrinsic-objects"> | ||
<h1>Well-known intrinsic objects</h1> | ||
<emu-table id="table-7" caption="Well-known Intrinsic Objects"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is Table 8 in ECMA-262 today. It might be easier leaving this as Table 1 or a non number identifier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is so that ecmarkup auto‑links <emu-xref href="#table-7" />
in this specification as local links, instead of links to https://tc39.es/ecma262/#table-7.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. The id remains with the wrong number.
@tc39/ecma262-editors Is this something we can change in ECMA-262? I mean, having a nominal id rather than numeric?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could change the legacy ID (and preserve it via an oldid) but it doesn't seem particularly important to change to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, let's keep the off-by-one then. :)
It doesn't need to be merged for this to land; the dotted intrinsic form landed a long time ago, and is preferred. |
It should be good enough to land, but I'd like @caridy's eyes here, which should happen this week. |
Legacy intrinsic aliases will be removed in tc39/ecma262#2056.