This repository has been archived by the owner on Jan 26, 2022. It is now read-only.
Remove unnecessary IsRegExp call from the string path in MatchAllIterator #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cc @peterwmwong |
|
LGTM |
ljharb
added a commit
to es-shims/String.prototype.matchAll
that referenced
this pull request
May 31, 2018
ljharb
added a commit
to es-shims/String.prototype.matchAll
that referenced
this pull request
May 31, 2018
peterwmwong
added a commit
to peterwmwong/test262
that referenced
this pull request
Jun 5, 2018
As per spec changes (tc39/proposal-string-matchall#35), removed tests related to the removed IsRegExp call. Also fix a misreference in `features` frontmatter.
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Jun 6, 2018
As per (tc39/proposal-string-matchall#35), the call to IsRegExp after CreateRegExp was removed and additional checking was replaced by an Assert. Updates to Test262 has been submitted: tc39/test262#1587 Bug: v8:6890 Change-Id: I942b6846bb46cf85b1ea5566f9c19de7d2dbf03e Reviewed-on: https://chromium-review.googlesource.com/1086419 Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Mathias Bynens <mathias@chromium.org> Commit-Queue: Peter Wong <peter.wm.wong@gmail.com> Cr-Commit-Position: refs/heads/master@{#53539}
peterwmwong
added a commit
to peterwmwong/test262
that referenced
this pull request
Jun 8, 2018
As per spec changes (tc39/proposal-string-matchall#35), removed tests related to the removed IsRegExp call. To prevent older implementations (not observing spec change) from passing, added a new test to verify the reduced number of observable calls to IsRegExp. Also fix a misreference in `features` frontmatter.
peterwmwong
added a commit
to peterwmwong/test262
that referenced
this pull request
Jun 8, 2018
As per spec changes (tc39/proposal-string-matchall#35), removed tests related to the removed IsRegExp call. To prevent older implementations (not observing spec change) from passing, added a new test to verify the reduced number of observable calls to IsRegExp. Also fix a misreference in `features` frontmatter.
chicoxyzzy
pushed a commit
to chicoxyzzy/test262
that referenced
this pull request
May 14, 2019
As per spec changes (tc39/proposal-string-matchall#35), removed tests related to the removed IsRegExp call. To prevent older implementations (not observing spec change) from passing, added a new test to verify the reduced number of observable calls to IsRegExp. Also fix a misreference in `features` frontmatter.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #34 (comment)
cc @anba