Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider deduplicating into IsCalendarUnit #2692

Closed
ptomato opened this issue Oct 5, 2023 · 1 comment
Closed

Consider deduplicating into IsCalendarUnit #2692

ptomato opened this issue Oct 5, 2023 · 1 comment
Labels
editorial

Comments

@ptomato
Copy link
Collaborator

ptomato commented Oct 5, 2023

After #2519 and #2612 there will be many instances of "If unit is "year", or unit is "month", or unit is "week", ..."

Consider refactoring this into an abstract operation, which could be called IsCalendarUnit. This should make several long lines in the spec more readable, as well as improve readability in the reference code.

Thanks to @Mrashes for the suggestion.
@ptomato ptomato mentioned this issue Oct 5, 2023
Merged
@Mrashes Mrashes mentioned this issue Oct 10, 2023
Merged
@Mrashes
Copy link
Contributor

Mrashes commented Oct 10, 2023

@ptomato opened a PR to merge. No rush as Its for after the others are merged.

@ptomato ptomato closed this as completed Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
editorial
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ptomato @Mrashes