Duration iscalendarunit

[Mrashes]

Refactor for legibility - #2692

Two errors that were triggering on test were present in branch previously

co-authored by El Linzer elinzer5@gmail.com

[ptomato]

Thanks for contributing!
We generally try to update the specification text along with the reference code at the same time. Any chance you would like to tackle that change as well?

[ptomato]

In this codebase we generally aren't using the one-export-per-file style; for now I'd suggest putting this into lib/ecmascript.mjs.

[Mrashes]

Will do! Also will try to update the spec text. Probably going to get to this this weekend.

[codecov]

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (40ca575) 96.61% compared to head (08f4bc7) 95.91%.
Report is 2 commits behind head on main.

❗ Current head 08f4bc7 differs from pull request most recent head ebdc729. Consider uploading reports for the commit ebdc729 to get more accurate results

Files	Patch %	Lines
polyfill/lib/timeduration.mjs	87.50%	17 Missing ⚠️
polyfill/lib/duration.mjs	95.91%	10 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2707      +/-   ##
==========================================
- Coverage   96.61%   95.91%   -0.70%     
==========================================
  Files          23       23              
  Lines       12229    11872     -357     
  Branches     2281     2338      +57     
==========================================
- Hits        11815    11387     -428     
- Misses        354      420      +66     
- Partials       60       65       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ptomato]

Now that the other duration changes have been merged, I finally was able to rebase this and add the spec text. Thanks for contributing and sorry for the long wait!