Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify & implement JSON representation for Temporal.Calendar as identifier #1273

Merged
merged 1 commit into from
Jan 13, 2021
Merged

Specify & implement JSON representation for Temporal.Calendar as identifier #1273

merged 1 commit into from
Jan 13, 2021

Conversation

cjtenny
Copy link
Collaborator

@cjtenny cjtenny commented Jan 13, 2021

Allows Calendar serialization to JSON.

Fixes #1227 separate from #1245

…tifier

Allows Calendar serialization to JSON.
@codecov
Copy link

codecov bot commented Jan 13, 2021

Codecov Report

Merging #1273 (62884ec) into main (5930868) will increase coverage by 2.25%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1273      +/-   ##
==========================================
+ Coverage   93.55%   95.81%   +2.25%     
==========================================
  Files          19       19              
  Lines        7961     9367    +1406     
  Branches     1264     1437     +173     
==========================================
+ Hits         7448     8975    +1527     
+ Misses        506      386     -120     
+ Partials        7        6       -1     
Flag Coverage Δ
test262 55.95% <ø> (+14.34%) ⬆️
tests 91.98% <ø> (+2.54%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
polyfill/lib/shim.mjs
polyfill/lib/legacydate.mjs
polyfill/lib/intrinsicclass.mjs
polyfill/lib/slots.mjs
lib/intrinsicclass.mjs 59.09% <0.00%> (ø)
lib/plainyearmonth.mjs 95.52% <0.00%> (ø)
lib/zoneddatetime.mjs 97.80% <0.00%> (ø)
lib/legacydate.mjs 0.00% <0.00%> (ø)
lib/now.mjs 100.00% <0.00%> (ø)
lib/plainmonthday.mjs 91.32% <0.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8e1fbf...f131bee. Read the comment docs.

Copy link
Collaborator

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍, the example code in the documentation is a bit contrived as we discussed on chat, but it's something we can fix later 😄

@ptomato ptomato merged commit 157f6d7 into tc39:main Jan 13, 2021
@cjtenny cjtenny deleted the cjtenny-1227 branch January 13, 2021 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON representation for Temporal.Calendar instances is always "{}"
2 participants