Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Fix various issues #1560

Merged
merged 12 commits into from
Jun 24, 2021
Merged

Editorial: Fix various issues #1560

merged 12 commits into from
Jun 24, 2021

Conversation

Ms2ger
Copy link
Collaborator

@Ms2ger Ms2ger commented Jun 23, 2021

Mostly from #1424.

@codecov
Copy link

codecov bot commented Jun 23, 2021

Codecov Report

Merging #1560 (33a91fe) into main (c2a7229) will decrease coverage by 3.26%.
The diff coverage is 100.00%.

❗ Current head 33a91fe differs from pull request most recent head a647903. Consider uploading reports for the commit a647903 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1560      +/-   ##
==========================================
- Coverage   95.58%   92.31%   -3.27%     
==========================================
  Files          19       17       -2     
  Lines       10933    10924       -9     
  Branches     1715     1616      -99     
==========================================
- Hits        10450    10085     -365     
- Misses        472      824     +352     
- Partials       11       15       +4     
Flag Coverage Δ
test262 ?
tests 91.38% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
polyfill/lib/plaindatetime.mjs 90.95% <100.00%> (-6.52%) ⬇️
polyfill/lib/plaintime.mjs 91.73% <100.00%> (-4.73%) ⬇️
polyfill/lib/plaindate.mjs 84.94% <0.00%> (-10.59%) ⬇️
polyfill/lib/plainmonthday.mjs 83.56% <0.00%> (-9.59%) ⬇️
polyfill/lib/timezone.mjs 86.27% <0.00%> (-7.19%) ⬇️
polyfill/lib/instant.mjs 87.50% <0.00%> (-7.10%) ⬇️
polyfill/lib/zoneddatetime.mjs 91.75% <0.00%> (-6.89%) ⬇️
polyfill/lib/plainyearmonth.mjs 89.77% <0.00%> (-6.63%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2a7229...a647903. Read the comment docs.

Copy link
Collaborator

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No major comments, feel free to merge after addressing the nitpicks

spec/temporal.html Show resolved Hide resolved
spec/plaindate.html Outdated Show resolved Hide resolved
spec/plaindate.html Outdated Show resolved Hide resolved
@Ms2ger Ms2ger merged commit 540e12b into main Jun 24, 2021
@Ms2ger Ms2ger deleted the various-editorial branch June 24, 2021 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants