Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kill PDT.round tests ported to Test262 #2139

Merged
merged 1 commit into from
Apr 12, 2022

Conversation

jessealama
Copy link
Collaborator

No description provided.

@jessealama jessealama requested a review from Ms2ger April 12, 2022 12:28
@jessealama
Copy link
Collaborator Author

jessealama commented Apr 12, 2022

Corresponds to this Test262 PR.

@codecov
Copy link

codecov bot commented Apr 12, 2022

Codecov Report

Merging #2139 (c2fd6a5) into main (01714a5) will decrease coverage by 8.28%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2139      +/-   ##
==========================================
- Coverage   92.28%   84.00%   -8.29%     
==========================================
  Files          19       17       -2     
  Lines       10905    10886      -19     
  Branches     1583     1385     -198     
==========================================
- Hits        10064     9145     -919     
- Misses        827     1708     +881     
- Partials       14       33      +19     
Flag Coverage Δ
test262 ?
tests 84.00% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
polyfill/lib/plainyearmonth.mjs 26.04% <0.00%> (-41.92%) ⬇️
polyfill/lib/plainmonthday.mjs 51.06% <0.00%> (-31.92%) ⬇️
polyfill/lib/plaintime.mjs 32.17% <0.00%> (-26.94%) ⬇️
polyfill/lib/plaindate.mjs 63.56% <0.00%> (-21.19%) ⬇️
polyfill/lib/plaindatetime.mjs 78.29% <0.00%> (-14.33%) ⬇️
polyfill/lib/instant.mjs 84.79% <0.00%> (-9.46%) ⬇️
polyfill/lib/now.mjs 91.22% <0.00%> (-8.78%) ⬇️
polyfill/lib/timezone.mjs 85.35% <0.00%> (-8.29%) ⬇️
polyfill/lib/zoneddatetime.mjs 91.28% <0.00%> (-7.23%) ⬇️
polyfill/lib/duration.mjs 90.35% <0.00%> (-5.32%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01714a5...c2fd6a5. Read the comment docs.

@ptomato ptomato marked this pull request as ready for review April 12, 2022 16:28
@ptomato
Copy link
Collaborator

ptomato commented Apr 12, 2022

Updated this with the test262 commit.

@ptomato ptomato merged commit 0fcd81f into tc39:main Apr 12, 2022
@ptomato ptomato added the no-spec-text PR can be ignored by implementors label May 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-spec-text PR can be ignored by implementors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants