Editorial: Refactor offset string formatting #2632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2632 +/- ##
==========================================
- Coverage 95.94% 95.94% -0.01%
==========================================
Files 20 20
Lines 11550 11542 -8
Branches 2197 2193 -4
==========================================
- Hits 11082 11074 -8
Misses 404 404
Partials 64 64
|
justingrant
force-pushed
the
refeactor-offset-formatting
branch
2 times, most recently
from
628947b
to
ccb2952
Compare
gibson042
reviewed
Jul 18, 2023
justingrant
force-pushed
the
refeactor-offset-formatting
branch
7 times, most recently
from
89a8d8e
to
15f95fb
Compare
|
OK, all review comments are addressed. PTAL. Thanks! |
justingrant
force-pushed
the
refeactor-offset-formatting
branch
from
15f95fb
to
de5a3cb
Compare
gibson042
approved these changes
Jul 19, 2023
justingrant
force-pushed
the
refeactor-offset-formatting
branch
2 times, most recently
from
6ca3b36
to
30b2304
Compare
Simplify offset formatting by using FormatTimeString instead of bespoke formatting logic. This commit completes the time-formatting refactor that tc39#2629 started.
justingrant
force-pushed
the
refeactor-offset-formatting
branch
from
30b2304
to
b3aea71
Compare
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Sep 13, 2023
Implements the changes from: - tc39/proposal-temporal#2621 - tc39/proposal-temporal#2622 - tc39/proposal-temporal#2632 - tc39/proposal-temporal#2607 Differential Revision: https://phabricator.services.mozilla.com/D185412
vinnydiehl
pushed a commit
to vinnydiehl/mozilla-unified
that referenced
this pull request
Sep 14, 2023
Implements the changes from: - tc39/proposal-temporal#2621 - tc39/proposal-temporal#2622 - tc39/proposal-temporal#2632 - tc39/proposal-temporal#2607 Differential Revision: https://phabricator.services.mozilla.com/D185412
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify offset formatting by using FormatTimeString instead of bespoke formatting logic for offsets. This commit completes the time-formatting refactor that #2629 started, and that I promised @gibson042 that I'd complete after #2574 and #2607 were merged.
This PR is stacked on #2622, so please review only the top commit.