Editorial: Follow up suggestions from Justin #3006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pattern is there because of #2729 and #2985. Abstract it into its own operation, for documentation purposes and because it can disappear after tc39/ecma262#1087 is fixed. See: #3005
This operation doesn't exist in the spec text, it's just an optimization to make the tests run faster. See: #3005
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3006 +/- ##
==========================================
+ Coverage 95.89% 95.92% +0.02%
==========================================
Files 21 21
Lines 9678 9674 -4
Branches 1837 1829 -8
==========================================
- Hits 9281 9280 -1
+ Misses 344 341 -3
Partials 53 53 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-ups from PR #3003.
Closes: #3005