Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rocket? #161

Closed
littledan opened this issue Oct 27, 2018 · 22 comments · Fixed by #174
Closed

Remove rocket? #161

littledan opened this issue Oct 27, 2018 · 22 comments · Fixed by #174

Comments

@littledan
Copy link
Member

I'm not sure how useful the "rocket" column is. It doesn't seem to be very up-to-date. Generally, the agendas are a more frequently updated data source for what's proposed for advancement. Should we remove this column?

@ljharb
Copy link
Member

ljharb commented Oct 29, 2018

Seems reasonable; I believe @rwaldron added it here (amusingly, it has precedent I found here). If there's no objections, we can certainly remove it.

@wmsbill
Copy link
Contributor

wmsbill commented Oct 29, 2018

As an outsider, I like to see the rocket, so that gives me a clue about the overall state of the proposals. As long as it stays up to date...

@Mouvedia
Copy link

It's particularly important for proposals with a lot of contentions, e.g. #.

@littledan
Copy link
Member Author

It just hasn't been staying up to date. Is there a problem with looking at agendas to find what's going for stage promotion?

@ljharb
Copy link
Member

ljharb commented Oct 29, 2018

If we decide to keep it, I can try to update it prior to each meeting, but it. does get tricky to do that without effort from proposal champions.

@Mouvedia
Copy link

@littledan at least you gotta link that agenda somewhere and not everyone has the time to read minutes.

@wmsbill
Copy link
Contributor

wmsbill commented Oct 29, 2018

It just hasn't been staying up to date. Is there a problem with looking at agendas to find what's going for stage promotion?

Not at all. I just have to spend more time to gather that information. I only think that the rocket is more accessible to the general audience.

@ljharb
Copy link
Member

ljharb commented Oct 29, 2018

@littledan
Copy link
Member Author

Note that, if we go with @ljharb 's plan in #161 (comment) , you'll have 10 days every two months with some more up-to-date information, and then back to just seeing what advanced for the rest of the cycle (with presumably no rockets posted).

@chicoxyzzy
Copy link
Member

Most of rockets are outdated most of time and don't reflect current state of proposals so they are misleading more than helping

@Mouvedia
Copy link

Just make a stage checklist for champions that includes a bullet PR on this repository, case closed.

@chicoxyzzy
Copy link
Member

chicoxyzzy commented Oct 31, 2018

Actually that's a good idea 👍

@chicoxyzzy
Copy link
Member

chicoxyzzy commented Oct 31, 2018

Oh actually I misunderstood @Mouvedia 😄 Sorry, IMHO it's not really a good idea to force someone to do something not useful for proposal at all.

What I actually though is that we can add a column with links to issues with stage status like this one tc39/proposal-global#12. Not every proposal repo has this but at least we can add status issues to some of proposals. This links doesn't change very often so they are much easier to maintain.

@littledan
Copy link
Member Author

littledan commented Oct 31, 2018

Could we tell people to check the upcoming agendas to learn about proposed advancement?

@lyleunderwood
Copy link

Agree with @littledan, fundamental issue seems to be that there's no direct route from proposals repo to agendas.

@ljharb
Copy link
Member

ljharb commented Oct 31, 2018

I could certainly add a sentence and a link to the top of this repo pointing to the agendas.

@chicoxyzzy
Copy link
Member

None of stage 0 proposals currently have a rocket. Maybe it's a good time to remove this column from that page? :)

@littledan
Copy link
Member Author

@chicoxyzzy Sounds good, and it'd be great to see a PR removing it from the main proposals page as well, replacing it with links to the agendas and notes pages.

@littledan
Copy link
Member Author

How should we come to a conclusion here? I can understand why these would be useful if updated, but that's not the current state. I'd like to suggest that we remove the rockets for now, while we don't have a way to keep them up to date, and consider adding them back when/if we develop a mechanism for that.

@ljharb
Copy link
Member

ljharb commented Dec 21, 2018

They’re up to date now as of 340f63c , and i can easily take a pass at them after the January meeting advancement agenda deadline passes.

I’d like to hear from someone about the original motivations for the column, so we can know why the fence exists before tearing it down.

@chicoxyzzy
Copy link
Member

Looking at motivation for adding new rocket in #180, it seems to me that rocket could be more informative if it links to https://github.com/tc39/agendas/blob/master/2019/01.md (in this particular case) or reflects date of meeting where it planned to be presented.

@littledan
Copy link
Member Author

@ljharb I'd imagine up-to-date rockets would include a rocket for decorators, and the rocket removed for throw expressions. If we can direct people to the next meeting's agenda, people will be able to see the presentation links if the champion posted one there, and we'll save ourselves the work of keeping multiple pages with the same information in sync.

ljharb pushed a commit to chicoxyzzy/proposals that referenced this issue Jan 8, 2019
ljharb pushed a commit to chicoxyzzy/proposals that referenced this issue Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants