Skip to content

Commit

Permalink
Split tests and fix false positive
Browse files Browse the repository at this point in the history
  • Loading branch information
leobalter authored and rwaldron committed Sep 27, 2021
1 parent c768b9b commit 10ad4c1
Show file tree
Hide file tree
Showing 2 changed files with 41 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,3 @@ new Proxy(fn, {});
assert.sameValue(typeof proxyCallable, 'function', 'wrapped proxy callable object is typeof function');
assert.sameValue(proxyCallable(), 42, 'wrappedpfn() returns 42');
assert.sameValue((new Proxy(proxyCallable, {}))(), 42, 'wrapped functions can be proxied');

const getSecret = r.evaluate(`(obj) => { return obj.secret }`);
const secretObj = { "secret": 496 };
const dispatchToUnderlying = {
apply: (target, this_, args) => { return target(args); }
};
assert.throws(TypeError, () => (new Proxy(getSecret, dispatchToUnderlying))(secretObj), 'Proxying a wrapped function and invoking it still performs boundary checks');
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
// Copyright (C) 2021 Rick Waldron. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.
/*---
esid: sec-shadowrealm.prototype.evaluate
description: >
Proxying a wrapped function and invoking it still performs boundary checks
features: [ShadowRealm]
---*/

assert.sameValue(
typeof ShadowRealm.prototype.evaluate,
'function',
'This test must fail if ShadowRealm.prototype.evaluate is not a function'
);

const r = new ShadowRealm();

const wrapped = r.evaluate(`() => { return 1; };`);

const secretObj = {x: 2};

let received;

const proxiedWrapped = new Proxy(wrapped, {
apply(target, _, args) {
assert.sameValue(target, wrapped);
received = args;

// Object can't be sent to the other Realm
return target({x: 1});
}
});

assert.throws(
TypeError,
() => proxiedWrapped(secretObj),
'Proxying a wrapped function and invoking it still performs boundary checks'
);

assert.sameValue(received[0], secretObj, 'proxy still calls the handler trap');
assert.sameValue(received.length, 1);

0 comments on commit 10ad4c1

Please sign in to comment.