Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect test expectation in type-calendar-valid.js #3139

Closed
anba opened this issue Aug 10, 2021 · 1 comment · Fixed by #3173
Closed

Incorrect test expectation in type-calendar-valid.js #3139

anba opened this issue Aug 10, 2021 · 1 comment · Fixed by #3173

Comments

@anba
Copy link
Contributor

anba commented Aug 10, 2021

The underscore tests in

assert.sameValue(typeof displayNames.of('123_abc'), 'string', '2 segments, minimum length, underscore');
assert.sameValue(typeof displayNames.of('12345678_abcdefgh'), 'string', '2 segments, maximum length, underscore');
assert.sameValue(typeof displayNames.of('123_abc_ABC'), 'string', '3 segments, minimum length, underscore');
assert.sameValue(typeof displayNames.of('12345678_abcdefgh_ABCDEFGH'), 'string', '3 segments, maximum length, underscore');
should all be moved to https://github.com/tc39/test262/blob/main/test/intl402/DisplayNames/prototype/of/type-calendar-invalid.js.

The underscore character "_" is only accepted for the sep production when the backwards-compatibility extensions are enabled. But in ECMA-402 we only accept Unicode BCP 47 locale identifiers, so identifiers without the backwards-compatibility extensions.

@jugglinmike
Copy link
Contributor

Thanks for reporting this! And for effectively writing the commit message. Correction under review here: gh-3173

Just when you think you know a programming language...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants