Correct tests for Unicode Language Identifier #3173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The underscore character "_" is only accepted for the sep production [1] when the backwards-compatibility extensions [2] are enabled. However, ECMA-402 only accepts Unicode BCP 47 locale identifiers [3], meaning identifiers *without* the backwards-compatibility extensions. [1] https://unicode.org/reports/tr35/#Unicode_language_identifier [2] https://unicode.org/reports/tr35/#BCP_47_Conformance [3] https://tc39.es/ecma402/#sec-language-tags
rwaldron
approved these changes
Sep 2, 2021
|
Thanks! :-) |
pull bot
pushed a commit
to Alan-love/v8
that referenced
this pull request
Sep 11, 2021
see tc39/test262#3173 Bug: v8:12167 Change-Id: I49bed6bf361dbc216a5174be16d747fe2b104208 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3152714 Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#76778}
|
make it clear in tc39/ecma402#647 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The underscore character "_" is only accepted for the sep production [1]
when the backwards-compatibility extensions [2] are enabled. However,
ECMA-402 only accepts Unicode BCP 47 locale identifiers [3], meaning
identifiers without the backwards-compatibility extensions.
[1] https://unicode.org/reports/tr35/#Unicode_language_identifier
[2] https://unicode.org/reports/tr35/#BCP_47_Conformance
[3] https://tc39.es/ecma402/#sec-language-tags
Resolves gh-3139. /cc @anba