intl tests for proposed additional options in options bag #1225
Conversation
This patch implements tests for the ECMA 402 PR at tc39/ecma402#175 It is based on the test test/intl402/Collator/10.1.1_19_c.js
|
Any updates here? |
|
Let's leave this open for another little bit; I need to update the patch and tests considering tc39/ecma402#175 (comment) |
| Tests that the options numberingSystem and calendar can be set through | ||
| either the locale or the options. | ||
| author: Norbert Lindenberg, Daniel Ehrenberg | ||
| includes: [testIntl.js] |
There was a problem hiding this comment.
This PR need to tag with features: ID since v8 is implementing this behind flag.
There was a problem hiding this comment.
I don't understand what you mean by "features: ID". You can also turn the flag on for these tests in test262.status.
There was a problem hiding this comment.
ok got it. LGTM could you land this?
| Tests that the options numberingSystem and calendar can be set through | ||
| either the locale or the options. | ||
| author: Norbert Lindenberg, Daniel Ehrenberg | ||
| includes: [testIntl.js] |
There was a problem hiding this comment.
This PR need to tag with features: ID since v8 is implementing this behind flag.
| Tests that the options numberingSystem and calendar can be set through | ||
| either the locale or the options. | ||
| author: Norbert Lindenberg, Daniel Ehrenberg | ||
| includes: [testIntl.js] |
There was a problem hiding this comment.
ok got it. LGTM could you land this?
|
We've concluded in ECMA-402 meetings that tc39/ecma402#175 is ready to land when the tests are ready, given that we have one implementation and repeated consensus. I think all of these are ready to land at this point. |
|
Could we land this so I can start testing my code in v8? |
This patch implements tests for the ECMA 402 PR at
tc39/ecma402#175 . It should not land until that spec patch lands.
It is based on the test test/intl402/Collator/10.1.1_19_c.js