Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for proposal-json-superset #1544

Merged
merged 3 commits into from
May 8, 2018

Conversation

gibson042
Copy link
Contributor

tc39/proposal-json-superset#9

Allow non-ASCII LineTerminator characters (U+2028 LINE SEPARATOR and U+2029 PARAGRAPH SEPARATOR) in string literals.

@ljharb
Copy link
Member

ljharb commented May 7, 2018

Duplicate of #1543; is there anything here that could be added there?

@mathiasbynens
Copy link
Member

mathiasbynens commented May 8, 2018

I’m fine with either #1543 or this patch.

Copy link
Member

@mathiasbynens mathiasbynens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

features.txt needs to be updated:

# ECMAScript ⊃ JSON
# https://github.com/tc39/proposal-json-superset
json-superset

And then the tests need the json-superset tag.

rwaldron
rwaldron previously approved these changes May 8, 2018
@rwaldron
Copy link
Contributor

rwaldron commented May 8, 2018

@gibson042 this is good to go with or without the update to features.txt and addition of json-superset (I can take care of it if you don't have time).

@leobalter
Copy link
Member

Bikeshedding some ideas to follow up in a new patch:

  • single quote strings
  • the .length property being affected by these characters
  • the .codePointAt returns
  • syntax being constructed through eval where a line separator is not allowed... e.g.: eval('async \u2029 function fn() {}') and eval('async \u2028 function fn() {}')

leobalter
leobalter previously approved these changes May 8, 2018
@gibson042 gibson042 dismissed stale reviews from leobalter and rwaldron via dbc0c6b May 8, 2018 18:19
@rwaldron
Copy link
Contributor

rwaldron commented May 8, 2018

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants