Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various bugs in test cases #1988

Merged
merged 1 commit into from
Dec 5, 2018
Merged

Conversation

anba
Copy link
Contributor

@anba anba commented Dec 5, 2018

  • src/class-elements/prod-private-async-method.case

  • test/language/expressions/class/private-methods/prod-private-async-method.js

  • test/language/statements/class/private-methods/prod-private-async-method.js

    • Use the value argument instead of calling #m() again, because the latter returns a new Promise object.
  • test/built-ins/Array/prototype/flatMap/non-callable-argument-throws.js

    • assert(...) requires a boolean argument, switch to assert.sameValue(...)
  • test/built-ins/Reflect/ownKeys/return-on-corresponding-order-large-index.js

  • test/intl402/NumberFormat/currencyDisplay-unit.js

    • The option value is "narrow-symbol" instead of "narrowSymbol".
  • test/intl402/NumberFormat/style-unit.js

    • "unit" style without a unit value leads to a TypeError, use the "generic" unit here.
  • test/intl402/Segmenter/iterator/following.js

  • test/intl402/Segmenter/iterator/preceding.js

    • Remove | 0 to ensure we actually test the ToIndex operation in the following resp. preceding methods.
    • ToIndex(1.4) is 1, so don't expect a TypeError for iter.preceding(1.4)
  • test/intl402/Segmenter/iterator/granularity.js

  • test/intl402/Segmenter/prototype/segment/segment-line.js

  • test/intl402/Segmenter/prototype/segment/segment-sentence.js

  • test/intl402/Segmenter/prototype/segment/segment-word.js

    • The initial value for breakType is always undefined.

Copy link
Member

@leobalter leobalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the fixes!

@@ -17,7 +17,7 @@ async #m() { return 42; }
//- constructor
assert.sameValue(this.#m.name, '#m', 'function name inside constructor');
ctorPromise = this.#m().then(value => {
assert.sameValue(this.#m(), 42, 'already defined in the ctor');
assert.sameValue(value, 42, 'already defined in the ctor');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops! Thanks again for catching this!

@leobalter leobalter merged commit b62dae4 into tc39:master Dec 5, 2018
@anba anba deleted the test-bugs-dec2018 branch June 25, 2020 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants