Tools: Update PyYAML version. #2279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ms2ger
commented
Aug 12, 2019
| @@ -154,20 +154,20 @@ def _frontmatter(self, case_filename, case_values): | |||
| features += self.attribs['meta'].get('features', []) | |||
| features = list(OrderedDict.fromkeys(features)) | |||
| if len(features): | |||
| lines += ['features: ' + re.sub('\n\s*', ' ', yaml.dump(features).strip())] | |||
| lines += ['features: ' + re.sub('\n\s*', ' ', yaml.dump(features, default_flow_style=True).strip())] | |||
There was a problem hiding this comment.
Default changed in yaml/pyyaml#256.
There was a problem hiding this comment.
It is weird how the library picks an option where a default option needs to explicitly set as True. The actual default action is without the default option is the equivalent of False. Sounds very counterintuitive.
Anyway, it's not a problem of Test262 and thanks for fixing this up.
leobalter
approved these changes
Aug 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2278.