Improve RegExp.prototype[@@replace] coverage #2481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shvaikalesh
force-pushed
the
regexp-prototype-symbol-replace
branch
from
a90e2b8
to
447837e
Compare
shvaikalesh
commented
Feb 11, 2020
| features: [Symbol.replace] | ||
| ---*/ | ||
|
|
||
| var r = /./; | ||
| var coercibleValue = { | ||
| length: 4, | ||
| index: 0, |
There was a problem hiding this comment.
This test was failing on JSC because it doesn't coerce index properly.
shvaikalesh
commented
Feb 11, 2020
| }, | ||
| 0: '', | ||
| 1: 'foo', | ||
| 2: 'bar', | ||
| 3: 'baz' | ||
| 3: 'baz', | ||
| index: 0, |
There was a problem hiding this comment.
This test was failing on JSC because it doesn't coerce index properly.
shvaikalesh
commented
Feb 11, 2020
| throw new Test262Error('This method should not be invoked.'); | ||
| }, | ||
| }, | ||
| index: 0, |
There was a problem hiding this comment.
This test was failing on JSC because it doesn't coerce index properly.
shvaikalesh
commented
Feb 11, 2020
| }; | ||
| r.exec = function() { | ||
| return coercibleIndex; | ||
| }; | ||
|
|
||
| assert.sameValue(r[Symbol.replace]('abcd', ''), 'ab'); | ||
| var replacer = function(_matched, position) { |
There was a problem hiding this comment.
This test was not failing on JSC even though it doesn't coerce index to integer.
|
@shvaikalesh Thanks for the extra notes! |
shvaikalesh
force-pushed
the
regexp-prototype-symbol-replace
branch
from
447837e
to
7a3b8f7
Compare
|
|
rwaldron
approved these changes
Mar 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSC bugs:
See also #2426.