Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for legacy RegExp features #2650

Merged
merged 4 commits into from
Sep 10, 2020
Merged

Add tests for legacy RegExp features #2650

merged 4 commits into from
Sep 10, 2020

Conversation

ExE-Boss
Copy link
Contributor

@ExE-Boss ExE-Boss commented Jun 7, 2020

This adds tests for the legacy RegExp features proposal:

  • Property descriptors of legacy static accessors
  • Cross‑realm and subclass calls of legacy static accessors
  • Cross‑realm and subclass calls of RegExp.prototype.compile

Resolves #2371
Resolves tc39/proposal-regexp-legacy-features#15

rwaldron
rwaldron requested changes Jun 10, 2020
View reviewed changes
Copy link
Contributor

@rwaldron rwaldron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect we'll need a new feature tag for this. Can you add legacy-regexp to features.txt, and then include it in all of these tests? Thanks!

@leobalter leobalter changed the base branch from master to main July 15, 2020 17:40
@leobalter
Copy link
Member

FYI, I updated the base branch from master to main.

@ExE-Boss ExE-Boss force-pushed the proposal-regacy-regexp-features/add-basic-tests branch from 77699f6 to 91f5191 Compare July 23, 2020 00:18
@ExE-Boss ExE-Boss requested review from leobalter and rwaldron July 23, 2020 00:22
This was referenced Jul 25, 2020
Closed
Closed
@rwaldron
Copy link
Contributor

@syg heads up for new failures in V8

@rwaldron rwaldron dismissed leobalter’s stale review September 10, 2020 20:07

Everything was fixed

@rwaldron rwaldron merged commit 9c754bc into tc39:main Sep 10, 2020
@ExE-Boss ExE-Boss deleted the proposal-regacy-regexp-features/add-basic-tests branch September 11, 2020 11:23
@ExE-Boss ExE-Boss mentioned this pull request Sep 23, 2020
Merged
Aye1Harris
Aye1Harris approved these changes Jul 18, 2021
View reviewed changes
features.txt Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aye1Harris Aye1Harris Aye1Harris approved these changes

@rwaldron rwaldron rwaldron approved these changes

@leobalter leobalter Awaiting requested review from leobalter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Write tests for test262 Missing coverage for Legacy RegExp features
4 participants
@ExE-Boss @leobalter @rwaldron @Aye1Harris