Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for Temporal.Calendar.prototype.dateUntil #3049

Merged
merged 7 commits into from
Aug 5, 2021
Merged

Add test for Temporal.Calendar.prototype.dateUntil #3049

merged 7 commits into from
Aug 5, 2021

Conversation

FrankYFTang
Copy link
Contributor

rwaldron
rwaldron requested changes Jul 19, 2021
View reviewed changes
Copy link
Contributor

@rwaldron rwaldron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be in a directory called "dateUntil"

@FrankYFTang
Copy link
Contributor Author

PTAL

@ptomato ptomato mentioned this pull request Jul 19, 2021
Open
FrankYFTang added a commit to FrankYFTang/test262 that referenced this pull request Jul 20, 2021
@FrankYFTang
porting over the Temporal asserts to temporalHelpers.js
283331c 
Per suggestion by tc39#3049 (comment)
@FrankYFTang FrankYFTang mentioned this pull request Jul 20, 2021
Merged
rwaldron pushed a commit that referenced this pull request Jul 21, 2021
@FrankYFTang @rwaldron
porting over the Temporal asserts to temporalHelpers.js
bd03c96 
Per suggestion by #3049 (comment)
@FrankYFTang
Copy link
Contributor Author

@jugglinmike PTAL, I use the new harness and add more tests. I also filed tc39/proposal-temporal#1689
since I have problem to create a test to let CreateTemporalDuration throw here.

@rwaldron rwaldron merged commit 750ec2b into tc39:main Aug 5, 2021
@FrankYFTang FrankYFTang deleted the calDateUntil branch August 9, 2021 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptomato ptomato ptomato left review comments

@rwaldron rwaldron rwaldron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FrankYFTang @rwaldron @ptomato