Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for Unicode v14 Identifier{Start,Part} #3198

Merged
merged 1 commit into from
Oct 16, 2021
Merged

Add tests for Unicode v14 Identifier{Start,Part} #3198

merged 1 commit into from
Oct 16, 2021

Conversation

mathiasbynens
Copy link
Member

@jugglinmike
Copy link
Contributor

@anba Would you mind also giving this a whirl in SpiderMonkey with Unicode 14?

@anba
Copy link
Contributor

anba commented Oct 6, 2021

The tests all pass when Unicode 14 is used.

jugglinmike
jugglinmike approved these changes Oct 16, 2021
View reviewed changes
Copy link
Contributor

@jugglinmike jugglinmike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you both!

@jugglinmike jugglinmike merged commit 5d3eed6 into tc39:main Oct 16, 2021
@mathiasbynens mathiasbynens deleted the unicode-14 branch September 14, 2022 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jugglinmike jugglinmike jugglinmike approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mathiasbynens @jugglinmike @anba