Shadow Realms: Check the function prototype of all points of wrapping #3269
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expanding the test added in #3230 to cover all points at which wrapping occurs in the Shadow Realm proposal.
I think I got the caller/target realm expectations correct, but definitely worth a close review
As a side note, I'm having some issues adapting the JSC implementation to satisfy this test and was offhand wondering: how important is the detail that the wrapped function's prototype pertains to the caller realm and not the target realm to the behavior of the feature?
cc/ @legendecas @rwaldron @leobalter