Fix resizable ArrayBuffer subarray tests #3671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is from the normative change in tc39/proposal-resizablearraybuffer#93, which got consensus in the March 2022 TC39.
|
@ptomato PTAL, thanks. |
ptomato
approved these changes
Sep 20, 2022
There was a problem hiding this comment.
Both seem correct to me, thanks. The one in the "grows" test does implement a change due to that normative PR which I missed the first time around. The one in the "shrinks" test seems to me that it should pass either way, by my reading, but maybe I missed something — it's been a couple of weeks since I last looked at these files.
|
Thanks for the review! At the time you converted the V8 tests, the V8 tests were also incorrect. We had forgotten to implement the normative change in tc39/proposal-resizablearraybuffer#93 until recently, which is why these were surfaced. |
catamorphism
pushed a commit
to catamorphism/test262
that referenced
this pull request
Oct 4, 2022
This is from the normative change in tc39/proposal-resizablearraybuffer#93, which got consensus in the March 2022 TC39.
catamorphism
pushed a commit
to catamorphism/test262
that referenced
this pull request
Oct 5, 2022
This is from the normative change in tc39/proposal-resizablearraybuffer#93, which got consensus in the March 2022 TC39.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is from the normative change in
tc39/proposal-resizablearraybuffer#93, which got consensus in the March 2022 TC39.