Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests for PR "Read date-time options only once when creating DateTimeFormat objects" #3768

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

anba
Copy link
Contributor

@anba anba commented Jan 12, 2023

Update tests for PR tc39/ecma402#709.

@gibson042
Copy link
Contributor

gibson042 commented Jan 14, 2023

I confirmed with engine262 that this PR includes the correct updates for tc39/ecma402#709: engine262/engine262@3248ccc...gibson042:ecma402-gh-709-initializedatetimeformat

But since test changes are required anyway, I'm proposing further improvements at tc39/ecma402#709 (comment) . Note also tc39/ecma402#747 , which suggests the possibility of future churn in this general area.

Copy link
Contributor

@gibson042 gibson042 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ptomato ptomato added the awaiting consensus This needs committee consensus before it can be eligible to be merged. label Feb 8, 2023
@FrankYFTang
Copy link
Contributor

LGTM

@FrankYFTang
Copy link
Contributor

The consensus was reach in Day 1 of TC39 2023-07 meeting.

@Ms2ger Ms2ger added awaiting specification and removed awaiting consensus This needs committee consensus before it can be eligible to be merged. labels Jul 25, 2023
@FrankYFTang
Copy link
Contributor

The PR is landed into ECMA402 in tc39/ecma402@02bd03a (not part of PR709 due to a technical mistake while merging)
please merge this PR

@Ms2ger Ms2ger enabled auto-merge (rebase) July 27, 2023 19:05
@Ms2ger Ms2ger merged commit 21c3097 into tc39:main Jul 27, 2023
1 check passed
@anba anba deleted the date-time-options-new branch September 28, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants