Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert array grouping tests to static methods #3830

Merged
merged 2 commits into from
May 31, 2023
Merged

Convert array grouping tests to static methods #3830

merged 2 commits into from
May 31, 2023

Conversation

ljharb
Copy link
Member

@ljharb ljharb commented May 19, 2023 •
edited
Loading

I deleted tests related to arraylikes and sparse arrays and ToLength, and added two tests around iterables.

@ljharb ljharb requested a review from jridgewell May 19, 2023 06:45
@ljharb ljharb requested a review from a team as a code owner May 19, 2023 06:45
@ljharb ljharb mentioned this pull request May 19, 2023
Closed
12 tasks
@ptomato
Copy link
Contributor

ptomato commented May 29, 2023

Can you double check the CI output?

/home/circleci/test262/test/built-ins/Map/groupBy/invalid-callback.js: INCLUDES - Unused include: "compareArray.js"
/home/circleci/test262/test/built-ins/Object/groupBy/invalid-callback.js: INCLUDES - Unused include: "compareArray.js"

@ljharb
Copy link
Member Author

ljharb commented May 30, 2023

Thanks, updated.

ptomato
ptomato approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We reviewed this in the maintainers meeting. 😄

@ptomato ptomato merged commit feb6f10 into main May 31, 2023
@ptomato ptomato deleted the group-statics branch May 31, 2023 15:32
@ljharb ljharb mentioned this pull request Jul 11, 2023
Closed
10 tasks
emanisay27

This comment was marked as spam.

Sign in to view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emanisay27 emanisay27 emanisay27 approved these changes

@ptomato ptomato ptomato approved these changes

@jridgewell jridgewell jridgewell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ljharb @ptomato @jridgewell @emanisay27