-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests for proposal-canonical-tz Stage 3 (will be merged into Temporal) #3837
Conversation
7c1328f
to
ad8a846
Compare
bc3809b
to
041e65e
Compare
041e65e
to
e7d9edf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This matches my understanding of the proposal.
Looks like there's a merge conflict in features.txt
, so it needs a rebase.
test/intl402/Temporal/TimeZone/from/timezone-case-insensitive.js
Outdated
Show resolved
Hide resolved
test/intl402/Temporal/TimeZone/prototype/equals/timezone-case-insensitive.js
Outdated
Show resolved
Hide resolved
test/intl402/Temporal/ZonedDateTime/from/timezone-case-insensitive.js
Outdated
Show resolved
Hide resolved
test/built-ins/Temporal/TimeZone/prototype/equals/argument-object.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review! I'll make the changes you recommend. Will try to get these changed before I present in 15 hours. :-)
test/built-ins/Temporal/TimeZone/prototype/equals/argument-object.js
Outdated
Show resolved
Hide resolved
I don't think it's necessary to rush! Having test262 tests merged is a requirement for stage 4, but not 3. Anyway the comments are just minor 😄 |
e7d9edf
to
8d840fa
Compare
All review feedback is resolved in the latest fixup commits. I'll autosquash them if this proposal achieves Stage 3 later tonight (my time), but figured that it'd be helpful to keep them separate for now so they're easier to review. |
@ptomato - let me know if you want to review the fixup commits that I made in response to your feedback. Otherwise I'll just rebase and autosquash them. Thanks! |
c472ab5
to
8dde64f
Compare
c50ba7b
to
38eaa3a
Compare
Marked as ready for review because this proposal reached Stage 3. Also made a few updates:
|
ae03d21
to
a2b7621
Compare
0b1547d
to
6a9a4b1
Compare
6a9a4b1
to
490ac24
Compare
This PR includes tests for the Time Zone Canonicalization proposal (proposal-canonical-tz) that reached Stage 3 at the July 2023 TC39 meeting.
At the same meeting, it was decided that this proposal should be merged into Temporal, so these tests are now part of tc39/proposal-temporal#2633.
Test roadmap
Temporal.TimeZone.p.equals
(the only new API in this proposal) Demitasse tests to Test262.Temporal.TimeZone
Demitasse tests to Test262.Temporal.ZonedDateTime
Demitasse tests to Test262.Intl.DateTimeFormat
Demitasse tests to Test262.