Tests for proposal-temporal#2607: Limit offset time zones to minutes precision #3862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justingrant
force-pushed
the
temporal-2607
branch
from
2feb190
to
2efae2b
Compare
ptomato
approved these changes
Jul 11, 2023
There was a problem hiding this comment.
Thanks. These look complete and match my understanding of the normative PR.
It's too bad that we can no longer test the matching behaviour in implementations without Intl, due to it only being supported in named time zones, but I don't see a way around that. Hopefully any implementations with named time zones but not full Intl compliance will still try to run the relevant sections of Intl tests.
test/built-ins/Temporal/Duration/compare/relativeto-sub-minute-offset.js
Show resolved
Hide resolved
91 tasks
justingrant
force-pushed
the
temporal-2607
branch
from
7b0e0a9
to
9e1758d
Compare
Modify/add tests for tc39/proposal-temporal#2607
justingrant
force-pushed
the
temporal-2607
branch
from
9e1758d
to
af0c8bc
Compare
|
There was apparently a blip in CircleCI where it failed to pull the branch from GitHub. I re-ran the required job. |
justingrant
added a commit
to justingrant/test262
that referenced
this pull request
Jul 21, 2023
This commit verifies that ISO strings with sub-minute offsets cannot be parsed into time zone identifiers. This was a change introduced in the recently-merged tc39/proposal-temporal#2607, but tests for this case were missing from tc39#3862 (the tests for that PR). I noticed in codecov results on an unrelated PR that this case wasn't being tested, so fixing that mistake now.
justingrant
added a commit
to justingrant/test262
that referenced
this pull request
Jul 21, 2023
This commit verifies that ISO strings with sub-minute offsets cannot be parsed into time zone identifiers. This was a change introduced in the recently-merged tc39/proposal-temporal#2607, but tests for this case were missing from tc39#3862 (the tests for that PR). I noticed in codecov results on an unrelated PR that this case wasn't being tested, so fixing that mistake now.
justingrant
added a commit
to justingrant/test262
that referenced
this pull request
Jul 21, 2023
This commit verifies that ISO strings with sub-minute offsets cannot be parsed into time zone identifiers. This was a change introduced in the recently-merged tc39/proposal-temporal#2607, but tests for this case were missing from tc39#3862 (the tests for that PR). I noticed in codecov results on an unrelated PR that this case wasn't being tested, so fixing that mistake now.
justingrant
added a commit
to justingrant/test262
that referenced
this pull request
Jul 21, 2023
This commit verifies that ISO strings with sub-minute offsets cannot be parsed into time zone identifiers. This was a change introduced in the recently-merged tc39/proposal-temporal#2607, but tests for this case were missing from tc39#3862 (the tests for that PR). I noticed in codecov results on an unrelated PR that this case wasn't being tested, so fixing that mistake now.
Ms2ger
pushed a commit
to justingrant/test262
that referenced
this pull request
Jul 25, 2023
This commit verifies that ISO strings with sub-minute offsets cannot be parsed into time zone identifiers. This was a change introduced in the recently-merged tc39/proposal-temporal#2607, but tests for this case were missing from tc39#3862 (the tests for that PR). I noticed in codecov results on an unrelated PR that this case wasn't being tested, so fixing that mistake now.
ptomato
pushed a commit
to justingrant/test262
that referenced
this pull request
Aug 9, 2023
This commit verifies that ISO strings with sub-minute offsets cannot be parsed into time zone identifiers. This was a change introduced in the recently-merged tc39/proposal-temporal#2607, but tests for this case were missing from tc39#3862 (the tests for that PR). I noticed in codecov results on an unrelated PR that this case wasn't being tested, so fixing that mistake now.
ptomato
pushed a commit
that referenced
this pull request
Aug 9, 2023
This commit verifies that ISO strings with sub-minute offsets cannot be parsed into time zone identifiers. This was a change introduced in the recently-merged tc39/proposal-temporal#2607, but tests for this case were missing from #3862 (the tests for that PR). I noticed in codecov results on an unrelated PR that this case wasn't being tested, so fixing that mistake now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests for Temporal normative PR tc39/proposal-temporal#2607: Limit offset time zones to minutes precision. EDIT: this PR reached consensus in the July 2023 TC39 meeting.
This is a draft PR until the corresponding Temporal PR is presented at the upcoming July 2023 TC39 plenary meeting.