Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for ECMA402 PR833 Allow locale based ignorePunctuation default #3922

Merged
merged 3 commits into from
Jun 27, 2024

Conversation

FrankYFTang
Copy link
Contributor

Test the default of Collator ignorePunctuation depens on locale not always false.
tc39/ecma402#833

@FrankYFTang FrankYFTang requested a review from a team as a code owner September 13, 2023 18:33
@FrankYFTang FrankYFTang changed the title Add test for ECMA402 833 Add test for ECMA402 833 Allow locale based ignorePunctuation default Sep 13, 2023
@FrankYFTang FrankYFTang changed the title Add test for ECMA402 833 Allow locale based ignorePunctuation default Add test for ECMA402 PR833 Allow locale based ignorePunctuation default Sep 13, 2023
@FrankYFTang
Copy link
Contributor Author

please add "awaiting specification" label

@FrankYFTang
Copy link
Contributor Author

This will be discuss in Oct TG2 first and bring to TC39 on 2023-Nov

@FrankYFTang
Copy link
Contributor Author

ECMA402 PR833 reach consensus in TC39 around 2024-02-06 11:25am PST tc39/ecma402#833

Copy link
Contributor

@anba anba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Assertion messages should be updated to use the correct language names.

@anba
Copy link
Contributor

anba commented Jun 24, 2024

@tc39/test262-maintainers: "awaiting specification" label can be removed and instead be replaced with "has consensus".

@Ms2ger Ms2ger added awaiting author has consensus This has committee consensus and removed awaiting specification labels Jun 24, 2024
@FrankYFTang
Copy link
Contributor Author

PTAL and merge this.

Copy link
Contributor

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

FrankYFTang and others added 3 commits June 27, 2024 03:34
…ion-default.js

Co-authored-by: André Bargull <andre.bargull@gmail.com>
…ion-default.js

Co-authored-by: André Bargull <andre.bargull@gmail.com>
@ptomato ptomato merged commit c3a326a into tc39:main Jun 27, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting author has consensus This has committee consensus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants