2022 10 26 prefixing password code part 2 #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with-password 2022 10 26 finish prefixing with password
* Following the pattern of prefixing password-specific code in Devise with `Password`, this explicitly labels the `Encryptor` as `PasswordEncryptor` and adds a `Devise::Encryptor` shim class
tcannonfodder
force-pushed
the
2022-10-26-prefixing-password-code-part-2
branch
from
d435cc7
to
620b024
Compare
* To begin the process of refactoring Devise to support passkeys, we need to decouple authentication from being specifically tied to passwords. * The first step is explicitly prefixing generically-named components like `ParameterSanitizer` with `Password`, since they concern password authentication
* To maintain compatability with exisiting installations, we need the `Devise::ParameterSanitizer` class. * This re-adds the class in, subclassing from `PasswordParameterSanitizer` and printing a deprecation warning
* Following the pattern of prefixing password-specific code in Devise with `Password`, this explicitly labels the `Devise::Models::Validatable` as `PasswordValidatable`, since it concerns the validation requirements when using passwords
* Following the pattern of prefixing password-specific code in Devise with `Password`, this explicitly labels the `Devise::Models::Authenticatable` as `PasswordAuthenticatable`, since it concerns authentication when using passwords
* Following the pattern of prefixing password-specific code in Devise with `Password`, this explicitly labels the `Devise::Models::DatabaseAuthenticatable` as `DatabasePasswordAuthenticatable`, since it concerns storing and using authentication when using passwords
* Following the pattern of prefixing password-specific code in Devise with `Password`, this explicitly labels the `Devise::Models::Recoverable` as `PasswordRecoverable`, since it concerns recovering a resource by resetting its password
* Following the pattern of prefixing password-specific code in Devise with `password`, this deprecates `Devise::Controllers::Helpers.devise_parameter_sanitizer`, replacing it with `Devise::Controllers::Helpers.devise_password_parameter_sanitizer` to make it explicit that the sanitizer handles password parameters
* Following the pattern of prefixing password-specific code in Devise with `Password`, this explicitly labels the `Devise::RegistrationsController` as `Devise::PasswordRegistrationsController`, since it concerns registering a user with a password as the authentication method
This was referenced Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: heartcombo#5527