Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: PHP_CodeSniffer #7

Merged
merged 1 commit into from
Dec 15, 2021
Merged

fix: PHP_CodeSniffer #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
"webclient/fake-http-client": "^1.0"
},
"scripts": {
"phpcs": "phpcs --help --report=checkstyle",
"phpcs": "phpcs --no-cache --report-full",
"phpmd": "phpmd src text phpmd",
"github:phpmd": "phpmd src github phpmd",
"phpstan": "phpstan analyse src --level=6",
Expand Down
2 changes: 0 additions & 2 deletions src/Model/Card.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

namespace TCGdex\Model;

use stdClass;
use TCGdex\Model\SubModel\Variants;
use TCGdex\Model\SubModel\Legal;
use TCGdex\Model\SubModel\Ability;
Expand All @@ -18,7 +17,6 @@
*/
class Card extends CardResume
{

protected function fill(object $data): void
{
foreach ($data as $key => $value) {
Expand Down
1 change: 0 additions & 1 deletion src/Model/CardResume.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

class CardResume extends Model
{

/**
* @var string
*/
Expand Down
1 change: 0 additions & 1 deletion src/Model/Model.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

abstract class Model
{

/**
* @var \TCGdex\TCGdex
*/
Expand Down
1 change: 0 additions & 1 deletion src/Model/Serie.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

class Serie extends SerieResume
{

/**
* @var SetResume[]
*/
Expand Down
1 change: 0 additions & 1 deletion src/Model/SerieResume.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

class SerieResume extends Model
{

/**
* @var string
*/
Expand Down
1 change: 0 additions & 1 deletion src/Model/SetResume.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@

class SetResume extends Model
{

/**
* @var string
*/
Expand Down
1 change: 0 additions & 1 deletion src/Model/StringEndpoint.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

class StringEndpoint extends Model
{

protected function fill(object $data): void
{
foreach ($data as $key => $value) {
Expand Down
1 change: 0 additions & 1 deletion src/Model/SubModel/Variants.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@

class Variants extends Model
{

/**
* @var string|null
*/
Expand Down
5 changes: 4 additions & 1 deletion src/Request.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@
*/
class Request
{
/**
* @param string|null $path
* @return mixed|null
*/
public static function fetch(...$path)
{
// Filter null elements as they break the rest
Expand Down Expand Up @@ -41,7 +45,6 @@ public static function fetch(...$path)

// Request is not cached
if (is_null($response)) {

// Request remote if there is no hit in the cache
$request = TCGdex::$requestFactory->createRequest('GET', $url);

Expand Down
4 changes: 3 additions & 1 deletion src/TCGdex.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,14 @@
*/
class TCGdex
{

/**
* @deprecated use TCGdex::getVersion()
*/
public const VERSION = "2.x.x";

/**
* @return string
*/
public static function getVersion()
{
try {
Expand Down