This repository has been archived by the owner on Apr 12, 2022. It is now read-only.
Apply the new design on the room avatar and name #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update room avatar icon
- Add rooms type
- replace e2e_verified with the new icons - fix the display of the avatars in the rooms list in case of file sharing
which. was not used
- Update the room activity avatar display
- Update Room settings header
- Update the room access by link activity header
- Update forum avatar in the rooms directory
- Update the room activity header
|
LGTM |
yostyle
approved these changes
Oct 26, 2020
| if (room.isEncrypted()) { | ||
| if (TextUtils.equals(roomAccessRule, RoomAccessRulesKt.RESTRICTED)) { | ||
| vRoomType.setText(R.string.tchap_room_private_room_type); | ||
| vRoomType.setTextColor(ContextCompat.getColor(context, R.color.tchap_coral_color)); |
There was a problem hiding this comment.
it's possible to use Spannable string instead of multiple textviews.
| @@ -195,6 +197,28 @@ public void populateViews(final Context context, | |||
| vRoomName.setText(displayName); | |||
| } | |||
|
|
|||
| if (null != vRoomType) { | |||
There was a problem hiding this comment.
Add a tool function that returns the room type. This function should be used in multiple cases.
Possible room types : PRIVATE, UNRESTRICTED or EXTERN, FORUM, DISCUSSION, UNKNOWN
There was a problem hiding this comment.
I agree, I will do it later
| if (mRoom.isEncrypted()) { | ||
| if (TextUtils.equals(roomAccessRule, RoomAccessRulesKt.RESTRICTED)) { | ||
| mActionBarTypeInfo.setText(R.string.tchap_room_long_private_room_type); | ||
| mActionBarTypeInfo.setTextColor(ContextCompat.getColor(this, R.color.tchap_coral_color)); |
There was a problem hiding this comment.
It's possible to use a Spannablestring instead of multiple textviews.
https://medium.com/androiddevelopers/spantastic-text-styling-with-spans-17b0c16b4568
vector/src/main/java/im/vector/activity/VectorRoomActivity.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Yoan Pintas <y.pintas@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#648