Skip to content
This repository has been archived by the owner on Apr 12, 2022. It is now read-only.

Room members: gray out the expired users #690

Merged
merged 6 commits into from
Mar 2, 2021
Merged

Room members: gray out the expired users #690

merged 6 commits into from
Mar 2, 2021

Conversation

yostyle
Copy link
Contributor

@yostyle yostyle commented Dec 7, 2020

@giomfo
Copy link
Contributor

giomfo commented Dec 9, 2020

I did some tests, I observed 2 issues:

  • one on server side: the /users/info return an error as soon as a remote userId is provided in the list.
  • another on this implementation, a loading wheel is displayed infinitely in case of error on getUsersInfo request

@giomfo
Copy link
Contributor

giomfo commented Dec 10, 2020

Update:

  • investigation is on progress for the first point
  • we should rewrite the code to be able to display the members list even in case of error

@yostyle yostyle force-pushed the yostyle/expired_account branch from e972652 to cb5e147 Compare February 1, 2021 18:20
giomfo added 3 commits March 1, 2021 23:19
@giomfo
Fix Exception: java.lang.RuntimeException: Can't create handler insid…
006cb11 
…e thread that has not called Looper.prepare()
@giomfo
Display the room members list before getting the userinfo data
d17e606 
This prevent a white screen during several seconds on huge rooms (ex: Tchap-info).
Consequence: we don't need to update the room members list on getUsersInfo failure
@giomfo
some improvements
ff91517
giomfo
giomfo approved these changes Mar 1, 2021
View reviewed changes
Copy link
Contributor

@giomfo giomfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yostyle
Copy link
Contributor Author

yostyle commented Mar 2, 2021

LGTM

@yostyle yostyle merged commit c837eb6 into develop Mar 2, 2021
@yostyle yostyle deleted the yostyle/expired_account branch March 2, 2021 08:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@giomfo giomfo giomfo approved these changes

Assignees

@giomfo giomfo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yostyle @giomfo