Disable key backup in the rebase version of the code #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giomfo
added a commit
that referenced
this pull request
Jun 4, 2020
* RoomViewController: Fix a crash when setting a nil string on UIPasteboard. * RoomSettingsViewController: Fix a crash when setting a nil string on UIPasteboard. * RoomViewController: Add logs when copy text failed. * RoomViewController: Fix crash occurring when tap on an unsent media with retrieved event equal to nil. * CocoaPods: Fix DTCoreText app extension issue. * Gemfile: Update CocoaPods version to 1.8.x and perform a bundle update. * Emoji picker: Fix reverse header and background colors (Fix #2630). * Update `setRootModule` method signature in NavigationRouterType protocol. * Device verification: Improve navigation flow and view states handling. * Settings: Add User-Interactive Auth for adding email and msidsn to user's account element-hq/element-ios#2744 * Settings: Use a generic wording when authentication flow is not supported * Add Tools/Logs/filterStartupLogs.sh * RoomVC: Prevent tableView scroll when displaying contextual menu (Fix #2687). * RoomVC: Prevent tableView scroll when displaying contextual menu. * Update GBDeviceInfo to version 6.3.0. * Update SwiftLint pod. * MXHTTPOperation: Remove nullability check before using `mutateTo:` method where needed. * AppDelegate: Handle updated MXBackgroundModeHandler and now use MXBackgroundTask. * Fix tab bar icons misalignment on iOS 13 (Fix #2802). * Integrations: Fix terms consent display when they are required * Integrations: Use the integrations manager provided by the homeserver admin via .well-known #2815 * Project: For each target use "$(inherited)" value for ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES build setting. * Update MatomoTracker pod to 7.2.0. * Integrations: Fix terms consent display when they are required (cherry picked from commit 394aedb) * Integrations: Fix terms consent display HTTP requests * SerializationService: Add deserialisation of Any with a dirty implementation of JSON dictionary parsing * Widgets: Check user permission before opening a widget (Data side) #2832 * Widgets permission: No check required when the user is the creator * Widgets permission: No check required for the integration manager widget * Widgets permission: Some cleaning * Widgets: Add a contextual menu to refresh, open outside and revoke the permission #2834 * Widgets: Add "Remove for everyone" to the contextual menu * Widgets permission: Fix Steve's remarks * Settings: Have a toggle for using an integration manager #2843 * Widgets: Display an error if the IM is disabled #2843 * Widgets: Change copy a bit in contextual menu * Widgets: Check user permission before opening a widget (data part) #2833 * Jitsi: Display room name, user name and user avatar in the conference screen * Swift: NSURL -> URL * Widgets: Fix bad i18n key * Convert message.mp3 to message.caf (IMA4) for compatibility with UNNotificationSound. * Room Widget Permission: Add close button assets. * Room Widget Permission: Add strings. * Add convenient `clamped` method to FloatingPoint. * Add convenient method to UIButton to set a background color as an image. * Create a SlidingModalPresenter that allows to present custom modal view controller or view in a card with a sliding transition. * Room Widget Permission: Create room widget permission screen. * Room Widget Permission: Handle new room widget permission UX in WidgetViewController. * Update Riot/Modules/Modal/SlidingModalPresentationAnimator.swift Co-Authored-By: manuroe <manuroe@users.noreply.github.com> * Update Riot/Modules/Modal/SlidingModalPresentationAnimator.swift Co-Authored-By: manuroe <manuroe@users.noreply.github.com> * Move sliding modal classes. * Update room widget permission strings. * Room widget permission: Update WidgetPermissionViewModel with permission string list and widget origin. * Room widget permission: Update WidgetPermissionViewController with closures instead of delegate handle updated view model. * Room widget permission: Update WidgetViewController. * Room widget permission: Use new widget permission UX for Jitsi. * Update changes * Room widget permission: Fix Jitsi widget permission wording. * Room widget permission: Disable justified text for permission informations in WidgetPermissionViewController. * WidgetPermissionViewController use a clear background for avatar image view. * Remove unused string. * Widgets: Handle terms display when selecting a widget in widget picker. * Fix terms appearing twice on cancel in IntegrationManagerViewController. * Widgets: Require scalar token validation to ensure terms display when retrieve widget URL. * Widgets: Update WidgetViewController to make it conform to all ServiceTermsModalCoordinatorBridgePresenterDelegate methods. * Accessibility: Make checkboxes accessible in terms of service screen. * Update Xcode reference from message.mp3 to message.caf. * Create a URL parser for room messages. * RoomVC: Handle tap and long tap on UITextView detected data other than links (Fix #2803). * Settings: Add cross-signing and key verification by direct message switches in labs section. * Device Verification: Stay in infinite waiting #2878 Don't stop listening to transaction updates if we receive unexpected events else you block the state machine. * NavigationRouter: Remove reference to former retained view controllers when change the root module.Add navigation logs. * DeviceVerificationCoordinatorBridgePresenter: Add navigation logs. * DeviceVerificationVerifyViewController: Wait view loading before observing device transaction change and unregister after matching an expected case. * DeviceVerificationIncomingViewController: Wait view loading before observing device transaction change and unregister after matching an expected case. * Settings: Hide cross-signing things from LABS for now * Remove RiotDesignValues files * Add generated Strings from Riot (VectorL10n enum) * Fix color issues * Fix compilation issues - Replace MediaPicker with ImagePickerPresenter in Settings - Add Riot source files * Move DeviceVerification files * Add DeviceVerification files to the Tchap project * Move ServiceTermsModal and SlidingModal files * fix compilation errors * Move Integration files into the Tchap sub-repo * Fix compilation errors * Move KeyBackup files into the Tchap sub-repo * Add KeyBackup files to the project * Move Room Contextual Menu stuff into the Tchap sub repo * fix compilation errors, add some assets * Fix last issues - Merge is ended TODO: - Tests all screen - Set up Key Backup and Device verification - Disable message Reaction/Edition * Fix Reaction display * Fix CountryPickerViewController tabBar * Setup keybackup (#286) * Set up the device verification (SAS Verification) #285 * Handle the key backup from the settings screen TODO: handle the key backup in case of pwd change (presently only key export is supported) * Handle the missing key backup in case of password change * Update Gemfile.lock * Adjust the Contacts handling * Remove the legacy `kAppDelegateDidTapStatusBarNotification` notif * Remove onBoardingManager from Tchap source * Room creation: fix imagePickerPresenter use * Fix compilation errors * Disable key backup in the rebase version of the code (#300) * Podfile: use temporarily a dinum branch for MatrixKit until a new rebase is applied on Tchap-ios in order to go back on the develop branch * SAS - Device Verification Adjustments (#301) - remove "share without verifying" option - start directly the verification based on emojis (without mentioning the legacy verification) - change the strings to focus on user's devices verification - Update the strings displayed during the legacy verification screen - Adjust layout - Update message when verification is cancelled - Bug Fix - DeviceVerificationVerifyViewController: the waitingPartnerLabel label was never displayed - Update the incoming request display * Update matrix-ios-sdk version * Bug Fix - The app may be stuck on the device verification screen (#302) * Bug Fix - The app may be stuck on the device verification screen This happens when several check of the pending room key requests are triggered simultaneously. For example when we resume the app after added a new device. This multiple requests involve an issue on the dialog handling (The screen is displayed, but the model lost its delegate) We fix this here by preventing the app from checking several times the pending requests * Bug Fix [Device verification] Only half of the key sharing requests are handled after verification Update sdk version (to get "MXCrypto: Only create one olm session at a time per device") #303
giomfo
added a commit
that referenced
this pull request
Jun 10, 2020
* RoomViewController: Fix a crash when setting a nil string on UIPasteboard. * RoomSettingsViewController: Fix a crash when setting a nil string on UIPasteboard. * RoomViewController: Add logs when copy text failed. * RoomViewController: Fix crash occurring when tap on an unsent media with retrieved event equal to nil. * CocoaPods: Fix DTCoreText app extension issue. * Gemfile: Update CocoaPods version to 1.8.x and perform a bundle update. * Emoji picker: Fix reverse header and background colors (Fix vector-im#2630). * Update `setRootModule` method signature in NavigationRouterType protocol. * Device verification: Improve navigation flow and view states handling. * Settings: Add User-Interactive Auth for adding email and msidsn to user's account vector-im#2744 * Settings: Use a generic wording when authentication flow is not supported * Add Tools/Logs/filterStartupLogs.sh * RoomVC: Prevent tableView scroll when displaying contextual menu (Fix vector-im#2687). * RoomVC: Prevent tableView scroll when displaying contextual menu. * Update GBDeviceInfo to version 6.3.0. * Update SwiftLint pod. * MXHTTPOperation: Remove nullability check before using `mutateTo:` method where needed. * AppDelegate: Handle updated MXBackgroundModeHandler and now use MXBackgroundTask. * Fix tab bar icons misalignment on iOS 13 (Fix vector-im#2802). * Integrations: Fix terms consent display when they are required * Integrations: Use the integrations manager provided by the homeserver admin via .well-known vector-im#2815 * Project: For each target use "$(inherited)" value for ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES build setting. * Update MatomoTracker pod to 7.2.0. * Integrations: Fix terms consent display when they are required (cherry picked from commit 394aedb) * Integrations: Fix terms consent display HTTP requests * SerializationService: Add deserialisation of Any with a dirty implementation of JSON dictionary parsing * Widgets: Check user permission before opening a widget (Data side) vector-im#2832 * Widgets permission: No check required when the user is the creator * Widgets permission: No check required for the integration manager widget * Widgets permission: Some cleaning * Widgets: Add a contextual menu to refresh, open outside and revoke the permission vector-im#2834 * Widgets: Add "Remove for everyone" to the contextual menu * Widgets permission: Fix Steve's remarks * Settings: Have a toggle for using an integration manager vector-im#2843 * Widgets: Display an error if the IM is disabled vector-im#2843 * Widgets: Change copy a bit in contextual menu * Widgets: Check user permission before opening a widget (data part) vector-im#2833 * Jitsi: Display room name, user name and user avatar in the conference screen * Swift: NSURL -> URL * Widgets: Fix bad i18n key * Convert message.mp3 to message.caf (IMA4) for compatibility with UNNotificationSound. * Room Widget Permission: Add close button assets. * Room Widget Permission: Add strings. * Add convenient `clamped` method to FloatingPoint. * Add convenient method to UIButton to set a background color as an image. * Create a SlidingModalPresenter that allows to present custom modal view controller or view in a card with a sliding transition. * Room Widget Permission: Create room widget permission screen. * Room Widget Permission: Handle new room widget permission UX in WidgetViewController. * Update Riot/Modules/Modal/SlidingModalPresentationAnimator.swift Co-Authored-By: manuroe <manuroe@users.noreply.github.com> * Update Riot/Modules/Modal/SlidingModalPresentationAnimator.swift Co-Authored-By: manuroe <manuroe@users.noreply.github.com> * Move sliding modal classes. * Update room widget permission strings. * Room widget permission: Update WidgetPermissionViewModel with permission string list and widget origin. * Room widget permission: Update WidgetPermissionViewController with closures instead of delegate handle updated view model. * Room widget permission: Update WidgetViewController. * Room widget permission: Use new widget permission UX for Jitsi. * Update changes * Room widget permission: Fix Jitsi widget permission wording. * Room widget permission: Disable justified text for permission informations in WidgetPermissionViewController. * WidgetPermissionViewController use a clear background for avatar image view. * Remove unused string. * Widgets: Handle terms display when selecting a widget in widget picker. * Fix terms appearing twice on cancel in IntegrationManagerViewController. * Widgets: Require scalar token validation to ensure terms display when retrieve widget URL. * Widgets: Update WidgetViewController to make it conform to all ServiceTermsModalCoordinatorBridgePresenterDelegate methods. * Accessibility: Make checkboxes accessible in terms of service screen. * Update Xcode reference from message.mp3 to message.caf. * Create a URL parser for room messages. * RoomVC: Handle tap and long tap on UITextView detected data other than links (Fix vector-im#2803). * Settings: Add cross-signing and key verification by direct message switches in labs section. * Device Verification: Stay in infinite waiting vector-im#2878 Don't stop listening to transaction updates if we receive unexpected events else you block the state machine. * NavigationRouter: Remove reference to former retained view controllers when change the root module.Add navigation logs. * DeviceVerificationCoordinatorBridgePresenter: Add navigation logs. * DeviceVerificationVerifyViewController: Wait view loading before observing device transaction change and unregister after matching an expected case. * DeviceVerificationIncomingViewController: Wait view loading before observing device transaction change and unregister after matching an expected case. * Settings: Hide cross-signing things from LABS for now * Remove RiotDesignValues files * Add generated Strings from Riot (VectorL10n enum) * Fix color issues * Fix compilation issues - Replace MediaPicker with ImagePickerPresenter in Settings - Add Riot source files * Move DeviceVerification files * Add DeviceVerification files to the Tchap project * Move ServiceTermsModal and SlidingModal files * fix compilation errors * Move Integration files into the Tchap sub-repo * Fix compilation errors * Move KeyBackup files into the Tchap sub-repo * Add KeyBackup files to the project * Move Room Contextual Menu stuff into the Tchap sub repo * fix compilation errors, add some assets * Fix last issues - Merge is ended TODO: - Tests all screen - Set up Key Backup and Device verification - Disable message Reaction/Edition * Fix Reaction display * Fix CountryPickerViewController tabBar * Setup keybackup (#286) * Set up the device verification (SAS Verification) #285 * Handle the key backup from the settings screen TODO: handle the key backup in case of pwd change (presently only key export is supported) * Handle the missing key backup in case of password change * Update Gemfile.lock * Adjust the Contacts handling * Remove the legacy `kAppDelegateDidTapStatusBarNotification` notif * Remove onBoardingManager from Tchap source * Room creation: fix imagePickerPresenter use * Fix compilation errors * Disable key backup in the rebase version of the code (#300) * Podfile: use temporarily a dinum branch for MatrixKit until a new rebase is applied on Tchap-ios in order to go back on the develop branch * SAS - Device Verification Adjustments (#301) - remove "share without verifying" option - start directly the verification based on emojis (without mentioning the legacy verification) - change the strings to focus on user's devices verification - Update the strings displayed during the legacy verification screen - Adjust layout - Update message when verification is cancelled - Bug Fix - DeviceVerificationVerifyViewController: the waitingPartnerLabel label was never displayed - Update the incoming request display * Update matrix-ios-sdk version * Bug Fix - The app may be stuck on the device verification screen (#302) * Bug Fix - The app may be stuck on the device verification screen This happens when several check of the pending room key requests are triggered simultaneously. For example when we resume the app after added a new device. This multiple requests involve an issue on the dialog handling (The screen is displayed, but the model lost its delegate) We fix this here by preventing the app from checking several times the pending requests * Bug Fix [Device verification] Only half of the key sharing requests are handled after verification Update sdk version (to get "MXCrypto: Only create one olm session at a time per device") #303
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#299