-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
55 add unit tests for room creation #120
55 add unit tests for room creation #120
Conversation
Je vais chipoter un peu mais pour moi les tests de components ne sont unitaires mais plutôt d'intégration (vu qu'il s'agit d'une dépendance externe au métier, que les tests sont plus lents et testent une collaboration). Après ça me choque pas plus que ça |
General note : we need to be easily able to tell what is our code and what is element's, for future rebases with element. |
Key learnings :
|
54d1085
to
97fc0e3
Compare
CI fails :
|
This PR adds unit tests for the TCHAP react component TchapCreateRoomDialog :
It uses the framework Jest and Enzyme with Snapshots.
Static and Module mocking is widely use as there is no dependency injection :/
Side note : TchapCreateRoom has been mutated to a static class to ease mocking.. Maybe not necessary
This PR currently has none of the required changelog labels.
A reviewer can add one of:
T-Deprecation
,T-Enhancement
,T-Defect
,T-Task
to indicate what type of change this is, or addType: [enhancement/defect/task]
to the description and I'll add them for you.