Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pipeline #136

Merged
merged 24 commits into from
Aug 29, 2022
Merged

Fix pipeline #136

merged 24 commits into from
Aug 29, 2022

Conversation

odelcroi
Copy link
Member

@odelcroi odelcroi commented Aug 24, 2022

What pipeline does

on PR :

  • build and run tests
  • check lint

details

add node engine version in github actions

 - uses: actions/setup-node@v3
        with:
          cache: 'yarn'
          node-version: 14
  1. add a new script to clone the correct version of matrix-react-sdk and matrix-js-sdk extracted from package.json

./scripts/layered.with.version.sh

  1. Deactivate temporary unnecessary workflows :
  • sonarqube
  • i18n check <--- to be investigated, could be usefull
  • custom logic for 'develop' branch
  • PR labels checks

This change is marked as an internal change (Task), so will not be included in the changelog.

@odelcroi odelcroi changed the title Pipeline failed because of node version Pipeline failed because of node version and more.. Aug 24, 2022
@odelcroi odelcroi changed the title Pipeline failed because of node version and more.. Fix pipeline Aug 25, 2022
Copy link
Contributor

@estellecomment estellecomment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

du coup cette PR elle builde quelle branche, et quand ? Je vois develop et master dans les yml.
Nous on voudrait surtout que ca build develop_tchap, et puis à chaque commit dans les PR.

src/components/views/dialogs/TchapServerPickerDialog.tsx Outdated Show resolved Hide resolved
scripts/layered.with.version.sh Show resolved Hide resolved
scripts/layered.with.version.sh Outdated Show resolved Hide resolved
@estellecomment estellecomment merged commit e02ec61 into develop_tchap Aug 29, 2022
@odelcroi odelcroi deleted the chore/test-node-version branch March 31, 2023 15:52
MarcWadai pushed a commit that referenced this pull request Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants