Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

185: second and third modals when clicking on save button #304

Merged
merged 14 commits into from
Nov 28, 2022

Conversation

aulamber
Copy link
Contributor

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

@estellecomment
Copy link
Contributor

estellecomment commented Nov 15, 2022

Testé sur la review app :

  • traduction manquante :

image

  • le lien "en savoir plus" pointe vers la page de register. C'est volontaire ?

  • sur le modal suivant, "Clés Tchap sauvegardées", le lien "en savoir plus" pointe aussi vers la page de register.

@estellecomment
Copy link
Contributor

Il y a un patch rename-exported-keys qui modifie le fichier ExportE2eKeysDialog.tsx (même probleme que la derniere fois)

Tu peux voir qu'il y a un patch si tu travailles avec un env avec yarn-linked-dependencies : une fois les patches appliqués (c'est fait avec yarn postinstall), tu peux voir que le fichier ExportE2eKeysDialog.tsx a des lignes modifiées. Donc c'est qu'un patch l'a modifié.

res/css/views/dialogs/_TchapExportE2eKeysDialog.pcss Outdated Show resolved Hide resolved
res/css/views/dialogs/_TchapExportE2eKeysDialog.pcss Outdated Show resolved Hide resolved
src/i18n/strings/tchap_translations.json Outdated Show resolved Hide resolved
src/i18n/strings/tchap_translations.json Outdated Show resolved Hide resolved
src/i18n/strings/tchap_translations.json Outdated Show resolved Hide resolved
res/css/views/dialogs/_TchapExportE2eKeysDialog.pcss Outdated Show resolved Hide resolved
res/css/views/dialogs/_TchapExportE2eKeysDialog.pcss Outdated Show resolved Hide resolved
@aulamber aulamber self-assigned this Nov 17, 2022
@odelcroi
Copy link
Member

odelcroi commented Nov 24, 2022

  • decide weither it is a regression or not (fix it now or file an issue) :

I found an expected behaviour (maybe not so dramatic let's see together)

  • In a logged session
  • Click on settings>privacy>export keys
  • Go on with the procedure
  • At the end there is a logout button whereas my intention was not to logout, only to export my keys

Capture d’écran 2022-11-24 à 14 46 51

In the actual version, when you export your keys from this panel, you are not invited to logout, the panel close and you stay in the logged session.

@odelcroi
Copy link
Member

odelcroi commented Nov 24, 2022

  • UX enhancement : devrait-on rappeler le nom du fichier dans cet écran ?

Capture d’écran 2022-11-24 à 14 46 51

Bonjour,
Suite à votre message ci dessous, j'ai commencé à sauvegarder mes clés tchap, mais je ne les retrouve plus. Désolé, comment pouvez vous m'aider ?
Merci

@estellecomment
Copy link
Contributor

Review app is not there, probably because there was inactivity for too long so I got deleted.
Closing and reopening the PR to trigger the re-creation of the review app, so that I can review.

@estellecomment
Copy link
Contributor

  • As we talked about together : one of the modals stays up after logout. It looks to me that it doesn't block the feature or create major misunderstanding or introduce a security problem, so I suggest filing an issue separately for this, to avoid delaying this PR.

image

@estellecomment
Copy link
Contributor

estellecomment commented Nov 28, 2022

  • UX enhancement : devrait-on rappeler le nom du fichier dans cet écran ?

It's called "tchap-keys.txt" in general, but when we save the file multiple times, it's called "tchap-keys(2).txt" (on macos for example). So we don't know the exact name of the file, the browser did the renaming.

image

@odelcroi
Copy link
Member

It's called "tchap-keys.txt" in general, but when we save the file multiple times, it's called "tchap-keys(2).txt" (on macos for example). So we don't know the exact name of the file, the browser did the renaming.

For better understanding, the "name in general" can be added and highlighted in the dialog text.

for instance : "... sauvegardées avec succès dans le fichier tchap-keys.txt..."

@aulamber aulamber merged commit 9c15d3a into develop_tchap Nov 28, 2022
@odelcroi odelcroi deleted the 185-second-modal-when-clicking-on-save-button branch March 31, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants