Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add patch to remove authorization header #314

Merged
merged 2 commits into from
Nov 23, 2022
Merged

add patch to remove authorization header #314

merged 2 commits into from
Nov 23, 2022

Conversation

odelcroi
Copy link
Member

@odelcroi odelcroi commented Nov 22, 2022 •
edited by estellecomment
Loading

Fixes #311

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

@odelcroi odelcroi linked an issue Nov 22, 2022 that may be closed by this pull request
"Forgot password" broken by element-web upgrade to v1.11.12 #311
Closed
estellecomment
estellecomment approved these changes Nov 23, 2022
View reviewed changes
Copy link
Contributor

@estellecomment estellecomment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works locally, and only modifies the client for PasswordReset, which is not reused elsewhere, so looks good !

@estellecomment
Copy link
Contributor

Patch should be removed when we upgrade to 1.11.13 or more. Added comment in issue to remember it : #308 (comment)

@estellecomment
Copy link
Contributor

estellecomment commented Nov 23, 2022 •
edited
Loading

Test on review app with dev backend :

  • bad header is gone
  • forgot password flow finishes without error
  • login with new password
  • messages appear, Authorization header is set, things look normal

Test on review app with prod backend :

  • bad header is gone
  • forgot password flow finishes without error
  • login with new password
  • messages appear, Authorization header is set, things look normal

@estellecomment estellecomment marked this pull request as ready for review November 23, 2022 10:45
@estellecomment estellecomment merged commit c75e33a into develop_tchap Nov 23, 2022
@odelcroi odelcroi deleted the 311-forgot-password-broken-by-element-web-upgrade-to-v11112 branch March 31, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estellecomment estellecomment estellecomment approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Forgot password" broken by element-web upgrade to v1.11.12
2 participants
@odelcroi @estellecomment