Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade/element web v1.11.17 #362

Merged
merged 150 commits into from
Jan 23, 2023
Merged

Conversation

aulamber
Copy link
Contributor

@aulamber aulamber commented Jan 9, 2023

Des diffs utiles, pour visualiser les changements plus facilement :
element-hq/element-web@v1.11.12...v1.11.17
matrix-org/matrix-react-sdk@v3.59.0...v3.63.0
matrix-org/matrix-js-sdk@v21.0.0...v23.0.0

Liste des patches à tester [Audrey] :

  • are-external-users-allowed-in-room
  • simplify-exchange-key-message
  • better-help-settings
  • content-scanner
  • disable-access-options
  • disable-cross-signing-and-enable-logout-devices-when-changing-password: vérifier le console.log
  • fix-key-request - Audrey
  • forgot-password - Estelle est dessus : Reimplement forgot password for element-web 1.11.17 #373
  • hide-cross-signing-actions
  • hide-room-alias-settings
  • hide-secure-storage
  • login
  • registration-for-mainlining
  • public-room-server-list
  • (Olivier) auto-accept-tac, j'ai créée un user sans avoir à accepter les tac
  • (Olivier) hide-discovery-email-phone-settings
  • (Olivier) hide-location-if-no-map-server
  • (Olivier) activate-expired-account-panel : j'ai desactivé par postman un user et reactiver en envoyant l'email de renew
  • (Olivier) user-friendlier-encrypted-messages
  • (Olivier) redo-key-sharing-after-own-device-verification - il doit disparaitre, pas la peine de le faire?
  • (Olivier) change-keys-in-room-summary-card
  • better-help-settings-2
  • (Estelle) remove-authorization-header-in-reset-password : on doit pouvoir l'enlever maintenant, a tester

A faire aussi :

  • lire le changelog d'element pour savoir s'il y a des nouvelles features ou des gros changements (le nouveau device manager ? The new device manager (labs feature) verifies current session and doesn't work #295). Rajouter dans la description de cette PR une liste de ces gros changements, pour qu'on puisse y revenir plus tard au besoin.
  • tester si ces gros changements marchent chez nous, ou causent des problemes, et si il faut les cacher ou faire un fix (On peut ignorer les features en labs)
  • (Estelle) réparer la CI
  • executer les tests cypress? c'est un travail à faire séparément, ils sont tous pétés

A tester pour valider la PR :

UX breaking changes (check translation):

optionnal

renovate bot and others added 30 commits October 20, 2022 15:27
* Update babel monorepo

* Update yarn.lock

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Put only high priority issues in front of the design team, all of which the design team will aim to action to keep the queue at zero.
# Conflicts:
#	yarn.lock
Z-Labs labels should be added to  A-Composer-WYSIWYG
I've been experimenting with loading WebAssembly into EW, for which I need to
use webpack's default wasm loader. Currently we're overriding that for *all*
files called `*.wasm`, which is too broad.

There are currently two `*.wasm` artifacts in EW: `decoderWorker.min.wasm`, and
`olm.wasm`. `decoderWorker` has its own rule, so the `*.wasm` rule is only used
for `olm.wasm`. So, let's tighten up the test for that rule so that it doesn't
catch other innocent `.wasm`s in the cross-fire.
All "good first issue" and "Hacktoberfest" qualify as "Help Wanted" so the label should be added automatically
# Conflicts:
#	package.json
#	yarn.lock
* Translated using Weblate (Finnish)

Currently translated at 100.0% (30 of 30 strings)

Translation: Element Web/element-web
Translate-URL: https://translate.element.io/projects/element-web/element-web/fi/

* Translated using Weblate (Dutch)

Currently translated at 100.0% (30 of 30 strings)

Translation: Element Web/element-web
Translate-URL: https://translate.element.io/projects/element-web/element-web/nl/

* Translated using Weblate (Romanian)

Currently translated at 100.0% (30 of 30 strings)

Translation: Element Web/element-web
Translate-URL: https://translate.element.io/projects/element-web/element-web/ro/

* Translated using Weblate (Romanian)

Currently translated at 100.0% (30 of 30 strings)

Translation: Element Web/element-web
Translate-URL: https://translate.element.io/projects/element-web/element-web/ro/

* Translated using Weblate (Romanian)

Currently translated at 100.0% (30 of 30 strings)

Translation: Element Web/element-web
Translate-URL: https://translate.element.io/projects/element-web/element-web/ro/

Co-authored-by: Jiri Grönroos <jiri.gronroos@iki.fi>
Co-authored-by: Weblate <translate@riot.im>
Co-authored-by: Roel ter Maat <roel.termaat@nedap.com>
Co-authored-by: mnbro <mihai.nicolae@protonmail.com>
Co-authored-by: Maros Dumitru <dimamaros@gmail.com>
@aulamber
Copy link
Contributor Author

J'ai enlevé dans /patches le repo registration car :

  1. c'était un doublon de registration-for-mainlining
  2. le patch n'était pas listé dans patches.json
  3. cela faisait planter le yarn install

@estellecomment
Copy link
Contributor

J'ai enlevé dans /patches le repo registration

C'est hyper louche qu'il y ait un dossier "registration" mais que le patch ne soit pas listé dans patches.json. A priori c'est une erreur, qqn a oublié de le supprimer.
Est-ce que tu peux retrouver la PR ou le commit qui a fait ca, et confirmer que c'est bien une erreur ?
J'ai fait une issue pour rajouter un check qui évite que cette situation arrive : #375

@odelcroi
Copy link
Member

odelcroi commented Jan 16, 2023

element-hq/element-web#22346 (comment)

Beware of the new support policy for the client-js . We are not impacted because our server uses the version X.X of matrix. Furthemore, the bug pointed out does not apply to Tchap because : we are not using Dendrite and we are using the correct api point /aliases

@odelcroi
Copy link
Member

odelcroi commented Jan 16, 2023

matrix-org/matrix-react-sdk#9549 (change sound notificaiton)

@odelcroi
Copy link
Member

new UI, nothing should be done IMHO :
Capture d’écran 2023-01-16 à 12 41 20

@odelcroi
Copy link
Member

Improve replies

Capture d’écran 2023-01-16 à 17 35 26

@odelcroi
Copy link
Member

A new feature : a welcome message !

Capture d’écran 2023-01-16 à 18 37 32

@odelcroi
Copy link
Member

Nouveau panel dans les room settings :

Capture d’écran 2023-01-17 à 11 57 25

@aulamber
Copy link
Contributor Author

Bug: #380

@aulamber
Copy link
Contributor Author

aulamber commented Jan 20, 2023

Autre problème :
Au login (qui fonctionne), redirection vers /login avec une popup d'erreur alors qu'il n'y a pas d'erreur.
Question de secure storage et de cross signing qui devrait être commenté. Sous un mois la fonctionnalité devrait être rajoutée donc le problème ne se posera plus.

Screenshot 2023-01-18 at 10 40 02

@odelcroi odelcroi closed this Jan 20, 2023
@odelcroi odelcroi reopened this Jan 20, 2023
* First version, works in basic case

* Hide server name cleanly

* Deal with case where server is not found

* Reset is not a state var and it is fine

* Sort out more edge cases

* Clean up liveliness checks

* Last cleanup

* Add translations

* Use new translation

* Remove patch remove-authorization-header-in-reset-password

* Add cherry-pick of matrix-react-sdk/pull/9925

* Move a comment in the patch

* Add cherry-pick of matrix-react-sdk/pull/9926
* Fix linter, Remove prettier from linter, our files are not prettier-formatted
@odelcroi odelcroi self-requested a review January 20, 2023 12:23
@odelcroi odelcroi merged commit df222ad into develop_tchap Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade element-web to 1.11.17 or more (jump 3 versions)