Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back e2e tests, locally #398

Merged
merged 10 commits into from
Feb 3, 2023
Merged

Bring back e2e tests, locally #398

merged 10 commits into from
Feb 3, 2023

Conversation

estellecomment
Copy link
Contributor

@estellecomment estellecomment commented Jan 30, 2023

Removed tests

  • for create DM, because afaik Tchap does not have any custom code for this, so Tchap should not be maintaining these tests. The tests were broken.
  • for external user login. There is nothing special about externals for login. The tests were skipped.

Other small things :

  • move utils dir, it was in test dir
  • fix linter in files that I edited
  • remove a useless import that was obsolete (browser-request)
  • fix small regression (data-test-id is now data-testid)

Tests pass locally, but not in CI.
Will deal with CI in another PR.

@estellecomment estellecomment marked this pull request as ready for review January 30, 2023 13:19
@estellecomment estellecomment changed the title Bring back e2e tests Bring back e2e tests, locally Jan 31, 2023
@odelcroi odelcroi merged commit e237327 into develop_tchap Feb 3, 2023
@odelcroi odelcroi deleted the bring-back-e2e-tests branch March 31, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants