In invite dialog add text indicating that we can invite multiple people #447
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| diff --git a/node_modules/matrix-react-sdk/res/css/views/dialogs/_InviteDialog.pcss b/node_modules/matrix-react-sdk/res/css/views/dialogs/_InviteDialog.pcss | ||
| index c03e78d..8f7854d 100644 | ||
| --- a/node_modules/matrix-react-sdk/res/css/views/dialogs/_InviteDialog.pcss | ||
| +++ b/node_modules/matrix-react-sdk/res/css/views/dialogs/_InviteDialog.pcss | ||
| @@ -38,7 +38,7 @@ limitations under the License. | ||
| min-height: 25px; | ||
| padding-inline-start: $spacing-8; | ||
| overflow-x: hidden; | ||
| - overflow-y: auto; | ||
| + overflow: auto; | ||
| display: flex; | ||
| flex-wrap: wrap; | ||
|
|
||
| @@ -194,6 +194,7 @@ limitations under the License. | ||
|
|
||
| .mx_InviteDialog_addressBar { | ||
| margin-inline-end: 0; | ||
| + overflow: auto; | ||
|
There was a problem hiding this comment. C'est une modification qui peut profiter à Element ? où c'est juste pour nous ? There was a problem hiding this comment. Ça leur serait utile à eux aussi, leur version est également buggée. Cf:
There was a problem hiding this comment. Du coup, je peux quand-même merger mon bugfix chez nous ou pas ? |
||
| } | ||
|
|
||
| .mx_InviteDialog_userSections { | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -722,5 +722,13 @@ | |
| "We'll generate a Security Key for you to store somewhere safe, like a password manager or a safe.": { | ||
| "fr": "Nous génèrerons une clé de récupération que vous devrez stocker dans un endroit sûr, comme un gestionnaire de mots de passe ou un coffre.", | ||
| "en": "We'll generate a Recovery Key for you to store somewhere safe, like a password manager or a safe." | ||
| }, | ||
| "Invite someone using their name, email address, username (like <userId/>) or <a>share this room</a>.": { | ||
| "fr": "Invitez quelqu’un via son nom, e-mail ou pseudo (p. ex. <userId/>) ou <a>partagez ce salon</a>. Il est possible d'inviter en masse en copiant et collant une liste d'emails séparés par une virgule (prenom1.nom1@beta.gouv.fr, prenom2.nom2@beta.gouv.fr, prenom3.nom3@beta.gouv.fr) ou séparés par un saut à la ligne.", | ||
|
There was a problem hiding this comment. @aulamber on n'a moyen de mettre des sauts de ligne ? There was a problem hiding this comment. Je n'y arrive pas en modifiant la string de traduction seulement. Par contre je peux faire un patch dans le code d'Element pour rajouter une div... mais je trouve que c'est lourd juste pour un saut à la ligne, qu'en penses-tu ? |
||
| "en": "Invite someone using their name, username (like <userId/>) or <a>share this room</a>. It is possible to invite multiple people by copy-pasting an email list separated by a comma (prenom1.nom1@beta.gouv.fr, prenom2.nom2@beta.gouv.fr, prenom3.nom3@beta.gouv.fr) or separated by a line break." | ||
| }, | ||
| "Invite someone using their name, email address, username (like <userId/>) or <a>share this space</a>.": { | ||
| "fr": "Invitez quelqu’un grâce à son nom, adresse e-mail, nom d’utilisateur (tel que <userId/>) ou <a>partagez cet espace</a>. Il est possible d'inviter en masse en copiant et collant une liste d'emails séparés par une virgule (prenom1.nom1@beta.gouv.fr, prenom2.nom2@beta.gouv.fr, prenom3.nom3@beta.gouv.fr) ou séparés par un saut à la ligne.", | ||
| "en": "Invite someone using their name, email address, username (like <userId/>) or <a>share this space</a>. It is possible to invite multiple people by copy-pasting an email list separated by a comma (prenom1.nom1@beta.gouv.fr, prenom2.nom2@beta.gouv.fr, prenom3.nom3@beta.gouv.fr) or separated by a line break." | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
du coup le "overflow-x: hidden;" devient inutile ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Je l'ai enlevé, tu as raison