-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New custom light theme #552
Conversation
can run "yarn prettier -w res" to remove the lint error? This way, it will create the review app, and we can test it live |
@areox-net des screenshots seraient cool pour voir les changement |
As we consider this theme as a "light", isn't the left bar too contrasted with the rest of the UI ? It looks too constrated to me |
I see your point, but the "light" theme is mostly defined by the background of the main containers. This sidebar is more like a vertical header (see Github header as a reference). In my opinion the contrast is justified. |
With a darker left bar : @areox-net ? |
@odelcroi It's not bad, but I would not go so far on desaturation. The color start being too violet. I think #222777 could be a good compromise between the current accent color and what you suggest. With this color for the sidebar we could even keep the current accent color I think. |
All good for me. |
Here is a PR to test the custom light theme.