Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New custom light theme #552

Merged
merged 7 commits into from
May 10, 2023
Merged

New custom light theme #552

merged 7 commits into from
May 10, 2023

Conversation

areox-net
Copy link
Contributor

Here is a PR to test the custom light theme.

@areox-net areox-net requested a review from odelcroi April 18, 2023 15:33
@odelcroi
Copy link
Member

odelcroi commented Apr 18, 2023

can run "yarn prettier -w res" to remove the lint error? This way, it will create the review app, and we can test it live

@odelcroi odelcroi marked this pull request as draft April 19, 2023 09:54
@odelcroi odelcroi linked an issue Apr 19, 2023 that may be closed by this pull request
@odelcroi
Copy link
Member

@areox-net des screenshots seraient cool pour voir les changement

@areox-net
Copy link
Contributor Author

Here is a quick before/after.

Before
Screenshot 2023-04-21 at 13 54 02

After
Screenshot 2023-04-21 at 13 53 55

@odelcroi
Copy link
Member

As we consider this theme as a "light", isn't the left bar too contrasted with the rest of the UI ? It looks too constrated to me

@areox-net
Copy link
Contributor Author

As we consider this theme as a "light", isn't the left bar too contrasted with the rest of the UI ? It looks too constrated to me

I see your point, but the "light" theme is mostly defined by the background of the main containers. This sidebar is more like a vertical header (see Github header as a reference). In my opinion the contrast is justified.

@odelcroi
Copy link
Member

odelcroi commented May 5, 2023

With a darker left bar : @areox-net ?
Capture d’écran 2023-05-05 à 10 43 58

@areox-net
Copy link
Contributor Author

@odelcroi It's not bad, but I would not go so far on desaturation. The color start being too violet. I think #222777 could be a good compromise between the current accent color and what you suggest. With this color for the sidebar we could even keep the current accent color I think.

Screenshot 2023-05-05 at 11 21 08

@odelcroi odelcroi marked this pull request as ready for review May 5, 2023 16:21
@odelcroi odelcroi closed this May 9, 2023
@odelcroi odelcroi reopened this May 9, 2023
@areox-net
Copy link
Contributor Author

All good for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not use red text when the user is mentioned.
2 participants