Use optional chaining to add listeners to optional UI elements. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because some UI elements are optional, code assuming they always exist was causing some of the JS to fail. Notably, the mobile menu was inoperable unless the '...' sidebar was enabled, since trying to add a listener to the non-existent sidebar button would error out the JS function before it could add the listener for the mobile menu. Same changes included in the minified js.
|
Thanks for your contribution, no doubt it's better with optionnal chaining. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because some UI elements are optional, code assuming they always exist was causing some of the JS to fail.
Notably, the mobile menu was inoperable unless the '...' sidebar was enabled, since trying to add a listener to the non-existent sidebar button would error out the JS function before it could add the listener for the mobile menu.
To reproduce the mentioned error, set
enable_sidebar = falsein your config.toml's[extra]and try serving or building--the mobile menu hamburger will do nothing, and opening the dev console will show a js error.